Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CADL API review step in spec PR failure when renaming to TypeSpec #5851

Closed
Tracked by #5761
praveenkuttappan opened this issue Mar 28, 2023 · 0 comments
Closed
Tracked by #5761

CADL API review step in spec PR failure when renaming to TypeSpec #5851

praveenkuttappan opened this issue Mar 28, 2023 · 0 comments
Assignees
@praveenkuttappan
Labels
Central-EngSys This issue is owned by the Engineering System team.

Comments

@praveenkuttappan
Copy link
Member

CADL API review step is triggered when PR has any changes related to CADL files. CADL files are considered as removed in a PR when CADL files are renamed to TypeSpec and eventually CADL API review gen fails when it can not find main.cadl.

We should complete CADL API review gen step gracefully instead of failing the job when main.cadl is missing in project root.

Error log:

error file-not-found: File /mnt/vss/_work/1/azure-rest-api-specs/specification/contosowidgetmanager/Contoso.WidgetManager/main.cadl not found.
@praveenkuttappan praveenkuttappan added the Central-EngSys This issue is owned by the Engineering System team. label Mar 28, 2023
@praveenkuttappan praveenkuttappan self-assigned this Mar 28, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in ApiView Mar 28, 2023
@praveenkuttappan praveenkuttappan moved this from 🆕 New to 🏗 In progress in ApiView Mar 28, 2023
@praveenkuttappan praveenkuttappan moved this from 🤔Triage to 🔬Dev in PR in Azure SDK EngSys 🚢🎉 Mar 28, 2023
This was referenced Mar 30, 2023
Closed
Closed
@praveenkuttappan praveenkuttappan moved this from 🏗 In progress to ✅ Done in ApiView Apr 3, 2023
@github-project-automation github-project-automation bot moved this from 🔬Dev in PR to 🎊Closed in Azure SDK EngSys 🚢🎉 Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@praveenkuttappan praveenkuttappan

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
ApiView
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@praveenkuttappan