Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unified pipeline - CADL API review gen step fails when converting project to tsp #5811

Closed
praveenkuttappan opened this issue Mar 24, 2023 · 1 comment
Closed

Unified pipeline - CADL API review gen step fails when converting project to tsp #5811

praveenkuttappan opened this issue Mar 24, 2023 · 1 comment
Labels
APIView Central-EngSys This issue is owned by the Engineering System team.

Comments

@praveenkuttappan
Copy link
Member

praveenkuttappan commented Mar 24, 2023 •
edited
Loading

CADL API review gen job in PR pipeline fails when converting existing CADL project to TypeSpec. CADL API review gen is triggered, and it finds that PR has some changes in CADL files even though these changes are to rename existing cadl to tsp files. Parser fails to find nay cadl files in the project folder and fails api review gen step.

Solution: We should ignore API review gen step for CADL if changes in PR for CADL files are only to rename to tsp files.
@praveenkuttappan praveenkuttappan added APIView Central-EngSys This issue is owned by the Engineering System team. labels Mar 24, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in ApiView Mar 24, 2023
@praveenkuttappan
Copy link
Member Author

Duplicate of #5851

@praveenkuttappan praveenkuttappan marked this as a duplicate of #5851 Mar 30, 2023
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in ApiView Mar 30, 2023
@github-project-automation github-project-automation bot moved this from 🤔Triage to 🎊Closed in Azure SDK EngSys 🚢🎉 Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
APIView Central-EngSys This issue is owned by the Engineering System team.
Projects
ApiView
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@praveenkuttappan