Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update migration script for java to only include src/session-records #5565

Closed
scbedd opened this issue Feb 23, 2023 · 0 comments · Fixed by #5568
Closed

Update migration script for java to only include src/session-records #5565

scbedd opened this issue Feb 23, 2023 · 0 comments · Fixed by #5568
Assignees
@scbedd
Labels
Asset-Sync Any issues relating to moving test assets out of repos. Central-EngSys This issue is owned by the Engineering System team.

Comments

@scbedd
Copy link
Member

scbedd commented Feb 23, 2023

After building, there also exists

target/session-records/<recordingName>.json

That the migration script is accidentally picking up because we're searching for all json files under the session-records name. Add a simple filter to include prefix as well.
@scbedd scbedd added the Central-EngSys This issue is owned by the Engineering System team. label Feb 23, 2023
@scbedd scbedd self-assigned this Feb 23, 2023
@scbedd scbedd added the Asset-Sync Any issues relating to moving test assets out of repos. label Feb 23, 2023
@scbedd scbedd mentioned this issue Feb 24, 2023
Merged
@ghost ghost closed this as completed in #5568 Feb 24, 2023
ghost pushed a commit that referenced this issue Feb 24, 2023
@scbedd
Adjust Migration Guidance + which files java transition run picks up (
54e579a 
#5568)

@billwert I had a local run of `appconfiguration` built locally for java, and my local verification absolutely omitted stuff from `target`.

Resolves #5565
@github-project-automation github-project-automation bot moved this from 🤔Triage to 🎊Closed in Azure SDK EngSys 🚢🎉 Feb 24, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scbedd scbedd

Labels
Asset-Sync Any issues relating to moving test assets out of repos. Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adjust Migration Guidance + which files java transition run picks up scbedd/azure-sdk-tools
1 participant
@scbedd