Move the test flag from get-codeowners.ps1 to the common PS1 test infra, common-tests
#5434
Assignees
Labels
Central-EngSys
This issue is owned by the Engineering System team.
Comments
ghost
added
the
needs-triage
konrad-jamrozik
added
the
Central-EngSys
konrad-jamrozik
changed the title
test flag from get-codeowners to the common PS1 test infratest flag from get-codeowners to the common PS1 test infra, common-tests
konrad-jamrozik
changed the title
test flag from get-codeowners to the common PS1 test infra, common-teststest flag from get-codeowners.ps1 to the common PS1 test infra, common-tests
konrad-jamrozik
removed
the
needs-triage
ghost
pushed a commit
that referenced
this issue
Mar 31, 2023
…vements & cleanup (#5608) This PR moves the `Test` flag away from `get-codeowners.ps1` to the established `eng/common-tests` infrastructure, using PowerShell Pester testing framework. As such, it solves: - #5434 This PR also: - adds a README for the `eng/common-tests`; - extracts the `get-codeowners.lib.ps1`, so that the functions can be reused between normal `get-codewners.ps1` usage and through Pester unit test invocations coming from `get-codeowners.tests.ps1`; - changes some paths for related scripts and test scripts; - moves some default params to `get-codeowners.lib.ps1` and hides some unused params; this was necessary to avoid default param value duplication between calls from `get-codeowners.ps1` and from `get-codeowners.tests.ps1`; - applies some refactorings. Associated changes made manually once this PR got merged: - deleted internal pipeline [tools - eng-common-tests](https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2605155&view=results); instead, created the public equivalent: [tools - eng-common-tests - ci](https://dev.azure.com/azure-sdk/public/_build?definitionId=5985). - For context, see [this comment](#5608 (comment)). Follow-up work: - #5878
github-project-automation
bot
moved this from 🔬Dev in PR
to 🎊Closed
in Azure SDK EngSys 🚢🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Per this comment:
get-codeowners.ps1to work with the updatedRetrieveCodeOwnersexecutable + add some tests; make assorted refactorings #5103 (comment)Related work:
matrix-generatortests and samples + make the tests runnable bycommon-tests/ci.yml. #5095The text was updated successfully, but these errors were encountered: