Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New-TestResources should warn when overwriting existing env variables with the subscription config #4931

Closed
benbp opened this issue Dec 9, 2022 · 1 comment · Fixed by #5242
Closed

New-TestResources should warn when overwriting existing env variables with the subscription config #4931

benbp opened this issue Dec 9, 2022 · 1 comment · Fixed by #5242
Assignees
@benbp
Labels
Central-EngSys This issue is owned by the Engineering System team.

Comments

@benbp
Copy link
Member

benbp commented Dec 9, 2022

This will make it easier to diagnose and debug implicit issues where someone defines the env variables twice, once in the yaml or local shell, and again from the sub config+arm template outputs.

CC @christothes
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 9, 2022
@kurtzeborn kurtzeborn added Central-EngSys This issue is owned by the Engineering System team. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Jan 23, 2023
@kurtzeborn kurtzeborn moved this from 🤔Triage to 📋Backlog in Azure SDK EngSys 🚢🎉 Jan 23, 2023
@benbp benbp mentioned this issue Jan 27, 2023
Merged
@ghost ghost closed this as completed in #5242 Jan 27, 2023
@github-project-automation github-project-automation bot moved this from 📋Backlog to 🎊Closed in Azure SDK EngSys 🚢🎉 Jan 27, 2023
ghost pushed a commit that referenced this issue Jan 27, 2023
@benbp
[test resources] Consolidate naming logic and generate short hash nam…
a03f747 
…es for local use (#5242)

Follow up fix related to discussion on Azure/azure-sdk-for-net#33262

- Make name generation simpler and more consistent across test resource scripts (found a bug where remove-testresources.ps1 would not have worked for nested service directories like data/aztables)
- Use a short hash for resource names deployed locally, to avoid edge cases where a long service directory or username causes resource names to be too long for validation (e.g. keyvault).
- Fix issue with `EnvironmentVariables` ref getting updated from the parameters when splatting in CI mode and polluting the env variable outputs on subsequent runs in the same shell.
- Add more warning logging if we're overwriting environment variables, for #4931

Fixes #4931
@benbp
Copy link
Member Author

benbp commented Jan 27, 2023

This is fixed now @christothes

@benbp benbp moved this from 🎊Closed to 🔬Dev in PR in Azure SDK EngSys 🚢🎉 Jan 27, 2023
@kurtzeborn kurtzeborn moved this from 🔬Dev in PR to 🎊Closed in Azure SDK EngSys 🚢🎉 Jan 31, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benbp benbp

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Milestone
No milestone
2 participants
@benbp @kurtzeborn