.NET Client SDK Analyzers .ctor rules firing false positives

[tg-msft]

Storage triggers the following analyzer rules but I think they're false positives:

• AZC0006: The guidelines show you can have optional *ClientOptions for your less important ctors per https://azuresdkspecs.z5.web.core.windows.net/DotNetSpec.html#dotnet-client-ctor-overloads but the rule appears to be more strict by demanding separate overloads

• AZC0007: This is looking for AppendBlobClientOptions instead of BlobClientOptions and firing

You can repro by removing the NoWarns at https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/storage/Directory.Build.props#L19

[kinelski]

Related: our guidelines state that:

If the options type can be shared by multiple client types, name it with a plural or more general name. For example, the BlobClientsOptions class can be used by BlobClient, BlobContainerClient, and BlobAccountClient.

However, we get an AZC0007 when using the ClientsOptions suffix.

[heaths]

I think this is out of date. According to current guidelines at https://azure.github.io/azure-sdk/dotnet_introduction.html#dotnet-client-constructor-no-default-params we should not use default params for constructors (including the req below that).