Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When tool generated PRs get a new iteration, the labels get reverted #1046

Closed
damirault opened this issue Sep 25, 2020 · 3 comments
Closed

When tool generated PRs get a new iteration, the labels get reverted #1046

damirault opened this issue Sep 25, 2020 · 3 comments
Assignees
@sima-zhu
Labels
Central-EngSys This issue is owned by the Engineering System team. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team.

Comments

@damirault
Copy link
Contributor

When a tool generated PR gets a new iteration pushed, any manually added labels get removed.

The AddLabels function is really a PUT labels function, overwriting existing labels.

azure-sdk-tools/eng/common/scripts/Submit-PullRequest.ps1

Line 61 in 1ea2117

function AddLabels([int] $prNumber, [string] $prLabelString)

Example of this happening:
image
Azure/azure-sdk-for-net#15285
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 25, 2020
@damirault damirault added the Central-EngSys This issue is owned by the Engineering System team. label Sep 25, 2020
@weshaggard
Copy link
Member

I added some investigation in #1047 (comment).

@damirault damirault mentioned this issue Sep 29, 2020
Merged
@sima-zhu
Copy link
Contributor

We have to read the labels out from the api first and add the parameter together with original labels. I can make a quick fix for this. Assign to me for now. Let me know if anyone has started the work already.

@sima-zhu sima-zhu self-assigned this Sep 29, 2020
@sima-zhu sima-zhu mentioned this issue Sep 29, 2020
Merged
@sima-zhu
Copy link
Contributor

Fixed by #1056
Closed the issue

sima-zhu pushed a commit to sima-zhu/azure-sdk-tools that referenced this issue Dec 3, 2020
@momuno
Embedded IoT Samples Refactor: Combine common code into sample.h and …
4c9acf3 
…sample.c. (Azure#1046)

* Common code from samples refactored into iot_sample_foundation.h: disable warnings; include files; logging macros; new NULL precondition check macro; all environment variable macros; new sample type and name structures; function declarations.

* Common code from samples refactored into iot_sample_foundation.hc: MQTT string literals to build endpoint; char buffers for SAS; functions - environment variables, creating MQTT endpoint, small helpers, and all SAS decoding/encoding functionality.

* Reorganize all samples (except pnp) to match, updating logging, structure, and removing returns at end of void functions.

* Simplifying function signatures for output of az_spans (removing redundancy to simplify the samples).

* Updates environment variables names to be consistent in naming. Adds PATH to end of cert/trust file path variables.

* Update all related documentation (README and how-to-guides) to reflect environment variable name changes and provide new output from logging.

* Other changes such as wording, naming of variables, checking for NULL pointers, etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sima-zhu sima-zhu

Labels
Central-EngSys This issue is owned by the Engineering System team. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@damirault @weshaggard @sima-zhu