Skip to content

Commit

Permalink
[Perf][Python] Don't install package in editable mode (#6652)
Browse files Browse the repository at this point in the history
The package doesn't need to be in editable mode, and we found that
this can cause issues when dev dependencies that share the same
namespace are installed alongside the main package.

Signed-off-by: Paul Van Eck <[email protected]>
  • Loading branch information
pvaneck authored Aug 3, 2023
1 parent 8e26181 commit e2fa3ae
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public class Python : LanguageBase
{
if (packageName == primaryPackage)
{
await Util.RunAsync(pip, "install -e .", projectDirectory, outputBuilder: outputBuilder, errorBuilder: errorBuilder);
await Util.RunAsync(pip, "install .", projectDirectory, outputBuilder: outputBuilder, errorBuilder: errorBuilder);
}
// TODO: Consider installing source versions of non-primary packages. Would require finding package in source tree.
// So far, this seems unnecessary, since dev-requirements.txt usually includes core.
Expand Down

0 comments on commit e2fa3ae

Please sign in to comment.