Stop retrying on 404s

Azure · May 21, 2024 · dc306c5 · dc306c5
1 parent 0febd98
commit dc306c5
Showing 1 changed file with 14 additions and 7 deletions.
diff --git a/tools/codeowners-utils/Azure.Sdk.Tools.CodeownersUtils/Utils/FileHelpers.cs b/tools/codeowners-utils/Azure.Sdk.Tools.CodeownersUtils/Utils/FileHelpers.cs
@@ -57,9 +57,10 @@ private static string GetUrlContents(string url)
             using HttpClient client = new HttpClient();
             while (attempts <= maxRetries)
             {
+                HttpResponseMessage response = null;
                 try
                 {
-                    HttpResponseMessage response = client.GetAsync(url).ConfigureAwait(false).GetAwaiter().GetResult();
+                    response = client.GetAsync(url).ConfigureAwait(false).GetAwaiter().GetResult();
                     if (response.StatusCode == HttpStatusCode.OK)
                     {
                         // This writeline is probably unnecessary but good to have if there are previous attempts that failed
@@ -76,13 +77,19 @@ private static string GetUrlContents(string url)
                     // HttpRequestException means the request failed due to an underlying issue such as network connectivity,
                     // DNS failure, server certificate validation or timeout.
                     Console.WriteLine($"GetUrlContents attempt number {attempts}. HttpRequestException trying to fetch {url}. Exception message = {httpReqEx.Message}");
-                    if (attempts == maxRetries)
-                    {
-                        // At this point the retries have been exhausted, let this rethrow
-                        throw;
-                    }
+
+                }
+
+                // Skip retries on a NotFound response
+                if (response?.StatusCode == HttpStatusCode.NotFound)
+                {
+                    return null;
+                }
+
+                if (attempts < maxRetries)
+                {
+                    System.Threading.Thread.Sleep(delayTimeInMs);
                 }
-                System.Threading.Thread.Sleep(delayTimeInMs);
                 attempts++;
             }
             // This will only get hit if the final retry is non-OK status code