Merge branch 'main' into net-analyzer/new-rules-from-mgmt

# Conflicts: # src/dotnet/Azure.ClientSdk.Analyzers/Azure.ClientSdk.Analyzers/Descriptors.cs
Azure · Oct 25, 2023 · 9c6636c · 9c6636c
2 parents 15faf32 + ca491bb
commit 9c6636c
Show file tree

Hide file tree

Showing 318 changed files with 12,904 additions and 4,060 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -30,8 +30,8 @@
 # Eng Sys Tools
 ###########
 /tools/                                @azure/azure-sdk-eng
-/tools/check-enforcer/                 @praveenkuttappan @weshaggard
 /tools/code-owners-parser/             @konrad-jamrozik @JimSuplizio
+/tools/codeowners-utils/               @JimSuplizio
 /tools/github-issues/                  @praveenkuttappan @weshaggard
 /tools/github-event-processor/         @JimSuplizio @benbp 
 /tools/github-team-user-store/         @JimSuplizio @weshaggard

diff --git a/.github/event-processor.config b/.github/event-processor.config
@@ -2,7 +2,6 @@
   "InitialIssueTriage": "On",
   "ManualIssueTriage": "On",
   "ServiceAttention": "Off",
-  "CXPAttention": "Off",
   "ManualTriageAfterExternalAssignment": "Off",
   "RequireAttentionForNonMilestone": "Off",
   "AuthorFeedbackNeeded": "Off",

diff --git a/.github/workflows/event-processor.yml b/.github/workflows/event-processor.yml
@@ -55,7 +55,7 @@ jobs:
         run: >
           dotnet tool install
           Azure.Sdk.Tools.GitHubEventProcessor
-          --version 1.0.0-dev.20230713.2
+          --version 1.0.0-dev.20231010.2
           --add-source https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-net/nuget/v3/index.json
           --global
         shell: bash

diff --git a/.github/workflows/scheduled-event-processor.yml b/.github/workflows/scheduled-event-processor.yml
@@ -34,7 +34,7 @@ jobs:
         run: >
           dotnet tool install
           Azure.Sdk.Tools.GitHubEventProcessor
-          --version 1.0.0-dev.20230713.2
+          --version 1.0.0-dev.20231010.2
           --add-source https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-net/nuget/v3/index.json
           --global
         shell: bash

diff --git a/doc/engsys_resource_management.md b/doc/engsys_resource_management.md
@@ -43,6 +43,9 @@ If you need the group for a little more time, add/update a tag named `DeleteAfte
 
 *To create long-lived resources:*
 
+NOTE: Resource groups in the playground subscription, if compliant and marked with valid aliases (see below), **will still
+be marked for deletion after 30 days.** See the below examples for how to extend this deletion deadline if necessary.
+
 Create a resource group to contain all testing resources. The resource group name should start with your Microsoft alias.
 Valid group name examples: `myalias`, `myalias-feature-101-testing`. Your Microsoft account must be
 [linked to your Github account](https://repos.opensource.microsoft.com/link).

diff --git a/...tomation/service-readme-generation/inputs/actual/latest/service-name-4-index.md b/...tomation/service-readme-generation/inputs/actual/latest/service-name-4-index.md
@@ -1,8 +1,7 @@
-| Reference | Package | Source |
-|---|---|---|
-|Communication Chat|[azure-communication-chat](azure-communication-chat/test)|[Github](github.com)|
-|Communication Identity|[azure-communication-identity](azure-communication-identity/test)|[Github](github.com/blob/main/sdk/communication/azure-communication-identity)|
-|Communication Network Traversal|[azure-communication-networktraversal](azure-communication-networktraversal/test)|[Github](github.com/blob/main/sdk/communication/azure-communication-networktraversal)|
-|Communication Phone Numbers|[azure-communication-phonenumbers](azure-communication-phonenumbers/test)|[Github](github.com)|
-|Communication Sms|[azure-communication-sms](azure-communication-sms/test)|[Github](github.com)|
-|Resource Management - Communication|[azure-mgmt-communication](azure-mgmt-communication/test)|[Github](github.com)|
+| Reference | Package | Source |
+|---|---|---|
+|Communication Chat|[azure-communication-chat](azure-communication-chat/test)|[GitHub](github.com)|
+|Communication Network Traversal|[azure-communication-networktraversal](azure-communication-networktraversal/test)|[GitHub](github.com/blob/main/sdk/communication/azure-communication-networktraversal)|
+|Communication Phone Numbers|[azure-communication-phonenumbers](azure-communication-phonenumbers/test)|[GitHub](github.com)|
+|Communication Sms|[azure-communication-sms](azure-communication-sms/test)|[GitHub](github.com)|
+|Resource Management - Communication|[azure-mgmt-communication](azure-mgmt-communication/test)|[GitHub](github.com)|
diff --git a/...doc-automation/service-readme-generation/inputs/actual/latest/service-name-4.md b/...doc-automation/service-readme-generation/inputs/actual/latest/service-name-4.md
@@ -1,13 +1,11 @@
----
-title: Azure service name 4 SDK for Unknown
-description: Reference for Azure service name 4 SDK for Unknown
-author: github-alias
-ms.author: msalias
-ms.data: 2022-11-01
-ms.topic: reference
-ms.devlang: Unknown
-ms.service: ms-service
----
-# Azure service name 4 SDK for Unknown - preview
-## Packages - preview
+---
+title: Azure service name 4 SDK for Unknown
+description: Reference for Azure service name 4 SDK for Unknown
+ms.date: 2022-11-01
+ms.topic: reference
+ms.devlang: Unknown
+ms.service: ms-service
+---
+# Azure service name 4 SDK for Unknown - preview
+## Packages - preview
 [!INCLUDE [packages](service-name-3-index.md)]
diff --git a/...omation/service-readme-generation/inputs/actual/preview/service-name-5-index.md b/...omation/service-readme-generation/inputs/actual/preview/service-name-5-index.md
@@ -1,7 +1,7 @@
-| Reference | Package | Source |
-|---|---|---|
-|Communication Chat|[azure-communication-chat](azure-communication-chat/test)|[Github](github.com)|
-|Communication Network Traversal|[azure-communication-networktraversal](azure-communication-networktraversal/test)|[Github](github.com/blob/main/sdk/communication/azure-communication-networktraversal)|
-|Communication Phone Numbers|[azure-communication-phonenumbers](azure-communication-phonenumbers/test)|[Github](github.com)|
-|Communication Sms|[azure-communication-sms](azure-communication-sms/test)|[Github](github.com)|
-|Resource Management - Communication|[azure-mgmt-communication](azure-mgmt-communication/test)|[Github](github.com)|
+| Reference | Package | Source |
+|---|---|---|
+|Communication Chat|[azure-communication-chat](azure-communication-chat/test)|[GitHub](github.com)|
+|Communication Network Traversal|[azure-communication-networktraversal](azure-communication-networktraversal/test)|[GitHub](github.com/blob/main/sdk/communication/azure-communication-networktraversal)|
+|Communication Phone Numbers|[azure-communication-phonenumbers](azure-communication-phonenumbers/test)|[GitHub](github.com)|
+|Communication Sms|[azure-communication-sms](azure-communication-sms/test)|[GitHub](github.com)|
+|Resource Management - Communication|[azure-mgmt-communication](azure-mgmt-communication/test)|[GitHub](github.com)|
diff --git a/...oc-automation/service-readme-generation/inputs/actual/preview/service-name-5.md b/...oc-automation/service-readme-generation/inputs/actual/preview/service-name-5.md
@@ -1 +1,9 @@
+---
+title: Azure service name 5 SDK for Unknown
+description: Reference for Azure service name 5 SDK for Unknown
+ms.date: 2022-11-01
+ms.topic: reference
+ms.devlang: Unknown
+ms.service: ms-service
+---
 This is testing
diff --git a/...omation/service-readme-generation/inputs/actual/preview/service-name-6-index.md b/...omation/service-readme-generation/inputs/actual/preview/service-name-6-index.md
@@ -1,8 +1,7 @@
-| Reference | Package | Source |
-|---|---|---|
-|Communication Chat|[azure-communication-chat](azure-communication-chat/test)|[Github](github.com)|
-|Communication Identity|[azure-communication-identity](azure-communication-identity/test)|[Github](github.com/blob/main/sdk/communication/azure-communication-identity)|
-|Communication Network Traversal|[azure-communication-networktraversal](azure-communication-networktraversal/test)|[Github](github.com/blob/main/sdk/communication/azure-communication-networktraversal)|
-|Communication Phone Numbers|[azure-communication-phonenumbers](azure-communication-phonenumbers/test)|[Github](github.com)|
-|Communication Sms|[azure-communication-sms](azure-communication-sms/test)|[Github](github.com)|
-|Resource Management - Communication|[azure-mgmt-communication](azure-mgmt-communication/test)|[Github](github.com)|
+| Reference | Package | Source |
+|---|---|---|
+|Communication Chat|[azure-communication-chat](azure-communication-chat/test)|[GitHub](github.com)|
+|Communication Network Traversal|[azure-communication-networktraversal](azure-communication-networktraversal/test)|[GitHub](github.com/blob/main/sdk/communication/azure-communication-networktraversal)|
+|Communication Phone Numbers|[azure-communication-phonenumbers](azure-communication-phonenumbers/test)|[GitHub](github.com)|
+|Communication Sms|[azure-communication-sms](azure-communication-sms/test)|[GitHub](github.com)|
+|Resource Management - Communication|[azure-mgmt-communication](azure-mgmt-communication/test)|[GitHub](github.com)|
diff --git a/...oc-automation/service-readme-generation/inputs/actual/preview/service-name-6.md b/...oc-automation/service-readme-generation/inputs/actual/preview/service-name-6.md
@@ -1,13 +1,11 @@
----
-title: Azure service name 6 SDK for Unknown
-description: Reference for Azure service name 6 SDK for Unknown
-author: github-alias
-ms.author: msalias
-ms.data: 2022-11-01
-ms.topic: reference
-ms.devlang: Unknown
-ms.service: ms-service
----
-# Azure service name 6 SDK for Unknown - preview
-## Packages - preview
+---
+title: Azure service name 6 SDK for Unknown
+description: Reference for Azure service name 6 SDK for Unknown
+ms.date: 2022-11-01
+ms.topic: reference
+ms.devlang: Unknown
+ms.service: ms-service
+---
+# Azure service name 6 SDK for Unknown - preview
+## Packages - preview
 [!INCLUDE [packages](service-name-5-index.md)]
diff --git a/...c-automation/service-readme-generation/inputs/expected/latest/service-name-2.md b/...c-automation/service-readme-generation/inputs/expected/latest/service-name-2.md
@@ -1,9 +1,7 @@
 ---
 title: Azure service name 2 SDK for Unknown
 description: Reference for Azure service name 2 SDK for Unknown
-author: github-alias
-ms.author: msalias
-ms.data: 2022-11-01
+ms.date: 2022-11-01
 ms.topic: reference
 ms.devlang: Unknown
 ms.service: ms-service

diff --git a/...c-automation/service-readme-generation/inputs/expected/latest/service-name-4.md b/...c-automation/service-readme-generation/inputs/expected/latest/service-name-4.md
@@ -1,9 +1,7 @@
 ---
 title: Azure service name 4 SDK for Unknown
 description: Reference for Azure service name 4 SDK for Unknown
-author: github-alias
-ms.author: msalias
-ms.data: 2022-11-01
+ms.date: 2022-11-01
 ms.topic: reference
 ms.devlang: Unknown
 ms.service: ms-service

diff --git a/...-automation/service-readme-generation/inputs/expected/preview/service-name-1.md b/...-automation/service-readme-generation/inputs/expected/preview/service-name-1.md
@@ -1,9 +1,7 @@
 ---
 title: Azure service name 1 SDK for Unknown
 description: Reference for Azure service name 1 SDK for Unknown
-author: github-alias
-ms.author: msalias
-ms.data: 2022-11-01
+ms.date: 2022-11-01
 ms.topic: reference
 ms.devlang: Unknown
 ms.service: ms-service

diff --git a/...-automation/service-readme-generation/inputs/expected/preview/service-name-3.md b/...-automation/service-readme-generation/inputs/expected/preview/service-name-3.md
@@ -1,9 +1,7 @@
 ---
 title: Azure service name 3 SDK for Unknown
 description: Reference for Azure service name 3 SDK for Unknown
-author: github-alias
-ms.author: msalias
-ms.data: 2022-11-01
+ms.date: 2022-11-01
 ms.topic: reference
 ms.devlang: Unknown
 ms.service: ms-service

diff --git a/...-automation/service-readme-generation/inputs/expected/preview/service-name-5.md b/...-automation/service-readme-generation/inputs/expected/preview/service-name-5.md
@@ -1,9 +1,7 @@
 ---
 title: Azure service name 5 SDK for Unknown
 description: Reference for Azure service name 5 SDK for Unknown
-author: github-alias
-ms.author: msalias
-ms.data: 2022-11-01
+ms.date: 2022-11-01
 ms.topic: reference
 ms.devlang: Unknown
 ms.service: ms-service

diff --git a/...-automation/service-readme-generation/inputs/expected/preview/service-name-6.md b/...-automation/service-readme-generation/inputs/expected/preview/service-name-6.md
@@ -1,9 +1,7 @@
 ---
 title: Azure service name 6 SDK for Unknown
 description: Reference for Azure service name 6 SDK for Unknown
-author: github-alias
-ms.author: msalias
-ms.data: 2022-11-01
+ms.date: 2022-11-01
 ms.topic: reference
 ms.devlang: Unknown
 ms.service: ms-service

diff --git a/eng/common-tests/get-codeowners/get-codeowners.tests.ps1 b/eng/common-tests/get-codeowners/get-codeowners.tests.ps1
diff --git a/eng/common/TestResources/New-TestResources.ps1 b/eng/common/TestResources/New-TestResources.ps1
@@ -771,7 +771,6 @@ try {
                     -TemplateParameterObject $templateFileParameters `
                     -Force:$Force
         }
-
         if ($deployment.ProvisioningState -ne 'Succeeded') {
             Write-Host "Deployment '$($deployment.DeploymentName)' has state '$($deployment.ProvisioningState)' with CorrelationId '$($deployment.CorrelationId)'. Exiting..."
             Write-Host @'
@@ -803,6 +802,9 @@ try {
             Write-Verbose "Removing compiled bicep file $($templateFile.jsonFilePath)"
             Remove-Item $templateFile.jsonFilePath
         }
+
+        Write-Host "Deleting ARM deployment as it may contain secrets. Deployed resources will not be affected."
+        $null = $deployment | Remove-AzResourceGroupDeployment
     }
 
 } finally {

diff --git a/eng/common/TestResources/Update-TestResources.ps1 b/eng/common/TestResources/Update-TestResources.ps1
@@ -26,7 +26,7 @@ param (
     [string] $SubscriptionId,
 
     [Parameter()]
-    [ValidateRange(1, 7*24)]
+    [ValidateRange(1, 30*24)]
     [int] $DeleteAfterHours = 48
 )
 
@@ -136,6 +136,9 @@ try {
 
     Log "Updating DeleteAfter to '$deleteAfter'"
     Write-Warning "Any clean-up scripts running against subscription '$SubscriptionId' may delete resource group '$ResourceGroupName' after $DeleteAfterHours hours."
+    if (!$resourceGroup.Tags) {
+        $resourceGroup.Tags = @{}
+    }
     $resourceGroup.Tags['DeleteAfter'] = $deleteAfter
 
     Log "Updating resource group '$ResourceGroupName'"

diff --git a/eng/common/pipelines/templates/steps/eng-common-workflow-enforcer.yml b/eng/common/pipelines/templates/steps/eng-common-workflow-enforcer.yml
@@ -11,7 +11,7 @@ steps:
 
         if ((!"$(System.PullRequest.SourceBranch)".StartsWith("sync-eng/common")) -and "$(System.PullRequest.TargetBranch)" -match "^(refs/heads/)?$(DefaultBranch)$")
         {
-          $filesInCommonDir  = & "eng/common/scripts/get-changedfiles.ps1" -DiffPath 'eng/common/*'
+          $filesInCommonDir  = & "eng/common/scripts/get-changedfiles.ps1" -DiffPath 'eng/common/*' -DiffFilterType ""
           if (($LASTEXITCODE -eq 0) -and ($filesInCommonDir.Count -gt 0))
           {
             Write-Host "##vso[task.LogIssue type=error;]Changes to files under 'eng/common' directory should not be made in this Repo`n${filesInCommonDir}"
@@ -21,7 +21,7 @@ steps:
         }
         if ((!"$(System.PullRequest.SourceBranch)".StartsWith("sync-.github/workflows")) -and "$(System.PullRequest.TargetBranch)" -match "^(refs/heads/)?$(DefaultBranch)$")
         {
-          $filesInCommonDir  = & "eng/common/scripts/get-changedfiles.ps1" -DiffPath '.github/workflows/*'
+          $filesInCommonDir  = & "eng/common/scripts/get-changedfiles.ps1" -DiffPath '.github/workflows/*' -DiffFilterType ""
           if (($LASTEXITCODE -eq 0) -and ($filesInCommonDir.Count -gt 0))
           {
             Write-Host "##vso[task.LogIssue type=error;]Changes to files under '.github/workflows' directory should not be made in this Repo`n${filesInCommonDir}"
@@ -30,4 +30,4 @@ steps:
           }
         }
       displayName: Prevent changes to eng/common and .github/workflows outside of azure-sdk-tools repo
-      condition: and(succeeded(), ne(variables['Skip.EngCommonWorkflowEnforcer'], 'true'), not(endsWith(variables['Build.Repository.Name'], '-pr')))
+      condition: and(succeeded(), ne(variables['Skip.EngCommonWorkflowEnforcer'], 'true'), not(endsWith(variables['Build.Repository.Name'], '-pr')))
diff --git a/eng/common/pipelines/templates/steps/sparse-checkout.yml b/eng/common/pipelines/templates/steps/sparse-checkout.yml
@@ -17,7 +17,10 @@ steps:
       - checkout: none
 
   - task: PowerShell@2
-    displayName: 'Sparse checkout repositories'
+    ${{ if eq(length(parameters.Repositories), 1) }}:
+      displayName: 'Sparse checkout ${{ parameters.Repositories[0].Name }}'
+    ${{ else }}:
+      displayName: 'Sparse checkout repositories'
     inputs:
       targetType: inline
       # Define this inline, because of the chicken/egg problem with loading a script when nothing
@@ -29,7 +32,7 @@ steps:
             if (!$dir) {
               $dir = "./$($repository.Name)"
             }
-            New-Item $dir -ItemType Directory -Force
+            New-Item $dir -ItemType Directory -Force | Out-Null
             Push-Location $dir
 
             if (Test-Path .git/info/sparse-checkout) {
@@ -70,9 +73,14 @@ steps:
 
             # sparse-checkout commands after initial checkout will auto-checkout again
             if (!$hasInitialized) {
-              Write-Host "git -c advice.detachedHead=false checkout $($repository.Commitish)"
+              # Remove refs/heads/ prefix from branch names
+              $commitish = $repository.Commitish -replace '^refs/heads/', ''
+
+              # use -- to prevent git from interpreting the commitish as a path
+              Write-Host "git -c advice.detachedHead=false checkout $commitish --"
+
               # This will use the default branch if repo.Commitish is empty
-              git -c advice.detachedHead=false checkout $($repository.Commitish)
+              git -c advice.detachedHead=false checkout $commitish --
             } else {
               Write-Host "Skipping checkout as repo has already been initialized"
             }

diff --git a/eng/common/pipelines/templates/steps/update-docsms-metadata.yml b/eng/common/pipelines/templates/steps/update-docsms-metadata.yml
@@ -100,10 +100,7 @@ steps:
           -Language '${{parameters.Language}}' `
           -RepoId '${{ parameters.RepoId }}' `
           -DocValidationImageId '${{ parameters.DocValidationImageId }}' `
-          -PackageSourceOverride '${{ parameters.PackageSourceOverride }}' `
-          -TenantId '$(opensource-aad-tenant-id)' `
-          -ClientId '$(opensource-aad-app-id)' `
-          -ClientSecret '$(opensource-aad-secret)'
+          -PackageSourceOverride '${{ parameters.PackageSourceOverride }}'
       displayName: Apply Documentation Updates
 
     - template: /eng/common/pipelines/templates/steps/git-push-changes.yml