Fixed the problem of not triggered by pull request.

Azure · Aug 17, 2020 · 753557b · 753557b
2 parents 4333bbc + 4a9ca5f
commit 753557b
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 17 deletions.
diff --git a/eng/common/Test.md b/eng/common/Test.md
diff --git a/eng/common/pipelines/templates/steps/azure-pipeline.yml b/eng/common/pipelines/templates/steps/azure-pipeline.yml
diff --git a/eng/common/pipelines/templates/steps/verify-links.yml b/eng/common/pipelines/templates/steps/verify-links.yml
@@ -15,4 +15,4 @@ steps:
         -rootUrl "file://$(Build.SourcesDirectory)/${{ parameters.Directory }}" 
         -recursive $false 
         -ignoreLinksFile ${{ parameters.IgnoreLinksFile }}
-        -branchReplaceRegex "(https://github.com/.*/blob/)link_replace_test(/.*)"
+        -branchReplaceRegex "(https://github.com/.*/blob/)link_replace_test(/.*)"
diff --git a/eng/common/scripts/Verify-Links.ps1 b/eng/common/scripts/Verify-Links.ps1
@@ -171,12 +171,21 @@ function CheckLink ([System.Uri]$linkUri)
   }
   $checkedLinks[$linkUri] = $true;
 }
-$ReplacementPattern = "`${1}$branchReplacementName`$2"
+
 function ReplaceGithubLink([string]$originLink) {
-  if ($branchReplacementName -eq "") {
-    return $originLink
+  if (-not $branchReplacementName) {
+    try {
+      $branchReplacementName = $(system.pullRequest.sourceCommitId)
+      if (-not $branchReplacementName) {
+        $ReplacementPattern = "`${1}$branchReplacementName`$2"
+        return $originLink -replace $branchReplaceRegex, $ReplacementPattern 
+      }
+    } 
+    catch {
+      Write-Verbose "It is not triggered by pull request. Skip the replace link steps."
+    }
   }
-  return $originLink -replace $branchReplaceRegex, $ReplacementPattern
+  return $originLink
 }
 
 function GetLinks([System.Uri]$pageUri)
@@ -217,7 +226,7 @@ function GetLinks([System.Uri]$pageUri)
 
   return $links;
 }
-Write-Host "Check the source commit var $(system.pullRequest.sourceCommitId)."
+
 if ($urls) {
   if ($urls.Count -eq 0) {
     Write-Host "Usage $($MyInvocation.MyCommand.Name) <urls>";