Skip strong name signing validation for secret cli (#6858)

Azure · Aug 28, 2023 · 69087b6 · 69087b6
1 parent 7361064
commit 69087b6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/eng/pipelines/templates/stages/archetype-sdk-tool-dotnet.yml b/eng/pipelines/templates/stages/archetype-sdk-tool-dotnet.yml
@@ -42,6 +42,9 @@ parameters:
   - name: ShouldPublishSymbols
     type: boolean
     default: true
+  - name: RequireStrongNames
+    type: boolean
+    default: true
 
 
 variables:
@@ -79,8 +82,8 @@ stages:
               DOTNET_MULTILEVEL_LOOKUP: 0
 
           # This step creates "$(packagesToPublishDir)" directory if it doesn't exist.
-          # This step is necessary since migration to net6.0. This is because since net6.0, 
-          # in case the "Build and Package" above would not output any packages to this directory, 
+          # This step is necessary since migration to net6.0. This is because since net6.0,
+          # in case the "Build and Package" above would not output any packages to this directory,
           # the "Publish to packages artifact" step below would fail on missing directory.
           - pwsh: |
               if (!(Test-Path -PathType container "$(packagesToPublishDir)")) {
@@ -155,9 +158,9 @@ stages:
               DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1
               DOTNET_CLI_TELEMETRY_OPTOUT: 1
               DOTNET_MULTILEVEL_LOOKUP: 0
-          
+
           - ${{ parameters.TestPostSteps }}
-          
+
           - task: PublishTestResults@2
             condition: succeededOrFailed()
             inputs:
@@ -181,6 +184,7 @@ stages:
         ExeMatrix: ${{ parameters.StandaloneExeMatrix }}
         ShouldPublishExecutables: ${{ parameters.ReleaseBinaries }}
         ShouldPublishSymbols: ${{ parameters.ShouldPublishSymbols }}
+        RequireStrongNames: ${{ parameters.RequireStrongNames }}
 
   - ${{if and(not(eq(length(parameters.DockerDeployments), 0)), ne(variables['Build.Reason'], 'PullRequest'), eq(variables['System.TeamProject'], 'internal'))}}:
     - stage: PublishDockerImages

diff --git a/tools/secret-management/ci.yml b/tools/secret-management/ci.yml
@@ -25,3 +25,5 @@ extends:
   template: /eng/pipelines/templates/stages/archetype-sdk-tool-dotnet.yml
   parameters:
     ToolDirectory: tools/secret-management
+    # Sodium.Core dependency is not strong name signed. Skip validation in order to sign secret cli.
+    RequireStrongNames: false