Only have a single DefinitionId for each type (#6675)

* Only have a single DefinitionId for each type * Removed `none:` attribute; fixed multiple duplicate deprecated attribute; removed extra space in defaulted parameters
Azure · Aug 4, 2023 · 3cb835d · 3cb835d
1 parent c554dad
commit 3cb835d
Show file tree

Hide file tree

Showing 6 changed files with 205 additions and 83 deletions.
diff --git a/tools/apiview/parsers/cpp-api-parser/ApiViewProcessor/AstDumper.cpp b/tools/apiview/parsers/cpp-api-parser/ApiViewProcessor/AstDumper.cpp
@@ -48,7 +48,7 @@ void AstDumper::OpenNamespace(std::string_view const& namespaceName)
   LeftAlign();
   InsertKeyword("namespace");
   InsertWhitespace();
-  InsertMemberName(namespaceName);
+  InsertIdentifier(namespaceName);
   InsertWhitespace();
   InsertPunctuation('{');
   AdjustIndent(namespaceIndent);

diff --git a/tools/apiview/parsers/cpp-api-parser/ApiViewProcessor/AstDumper.hpp b/tools/apiview/parsers/cpp-api-parser/ApiViewProcessor/AstDumper.hpp
@@ -38,11 +38,12 @@ class AstDumper {
   virtual void InsertText(std::string_view const& text) = 0;
   virtual void InsertPunctuation(char punctuation) = 0;
   virtual void InsertLineIdMarker() = 0;
+  virtual void InsertIdentifier(std::string_view const& identifier) = 0;
   virtual void InsertTypeName(
       std::string_view const& type,
       std::string_view const& typeNavigationId)
       = 0;
-  virtual void InsertMemberName(std::string_view const& member) = 0;
+  virtual void InsertMemberName(std::string_view const& member, std::string_view const& memberFullName) = 0;
   virtual void InsertStringLiteral(std::string_view const& str) = 0;
   virtual void InsertLiteral(std::string_view const& str) = 0;
   virtual void InsertComment(std::string_view const& comment) = 0;