update

Azure · Aug 2, 2023 · 14554b1 · 14554b1
1 parent ece6ad4
commit 14554b1
Show file tree

Hide file tree

Showing 7 changed files with 94 additions and 81 deletions.
diff --git a/src/dotnet/Azure.ClientSdk.Analyzers/Azure.ClientSdk.Analyzers.Tests/AZC0002Tests.cs b/src/dotnet/Azure.ClientSdk.Analyzers/Azure.ClientSdk.Analyzers.Tests/AZC0002Tests.cs
@@ -13,19 +13,21 @@ public class AZC0002Tests
         public async Task AZC0002ProducedForMethodsWithoutCancellationTokenOrRequestContext()
         {
             const string code = @"
+using Azure;
 using System.Threading.Tasks;
 
 namespace RandomNamespace
 {
     public class SomeClient
     {
-        public virtual Task {|AZC0002:GetAsync|}()
+        public virtual Response {|AZC0002:GetAsync|}()
         {
             return null;
         }
 
-        public virtual void {|AZC0002:Get|}()
+        public virtual Response {|AZC0002:Get|}()
         {
+            return null;
         }
     }
 }";
@@ -38,20 +40,22 @@ await Verifier.CreateAnalyzer(code)
         public async Task AZC0002ProducedForMethodsWithWrongNameCancellationToken()
         {
             const string code = @"
+using Azure;
 using System.Threading;
 using System.Threading.Tasks;
 
 namespace RandomNamespace
 {
     public class SomeClient
     {
-        public virtual Task {|AZC0002:GetAsync|}(CancellationToken cancellation = default)
+        public virtual Response {|AZC0002:GetAsync|}(CancellationToken cancellation = default)
         {
             return null;
         }
 
-        public virtual void {|AZC0002:Get|}(CancellationToken cancellation = default)
+        public virtual Response {|AZC0002:Get|}(CancellationToken cancellation = default)
         {
+            return null;
         }
     }
 }";
@@ -65,20 +69,22 @@ public async Task AZC0002ProducedForMethodsWithWrongNameRequestContext()
         {
             const string code = @"
 using Azure;
+using Azure.Core;
 using System.Threading;
 using System.Threading.Tasks;
 
 namespace RandomNamespace
 {
     public class SomeClient
     {
-        public virtual Task {|AZC0002:GetAsync|}(RequestContext cancellation = default)
+        public virtual Response {|AZC0002:GetAsync|}(RequestContext cancellation = default)
         {
             return null;
         }
 
-        public virtual void {|AZC0002:Get|}(RequestContext cancellation = default)
+        public virtual Response {|AZC0002:Get|}(RequestContext cancellation = default)
         {
+            return null;
         }
     }
 }";
@@ -91,20 +97,22 @@ await Verifier.CreateAnalyzer(code)
         public async Task AZC0002ProducedForMethodsWithNonOptionalCancellationToken()
         {
             const string code = @"
+using Azure;
 using System.Threading;
 using System.Threading.Tasks;
 
 namespace RandomNamespace
 {
     public class SomeClient
     {
-        public virtual Task {|AZC0002:GetAsync|}(CancellationToken cancellationToken)
+        public virtual Response {|AZC0002:GetAsync|}(CancellationToken cancellationToken)
         {
             return null;
         }
 
-        public virtual void {|AZC0002:Get|}(CancellationToken cancellationToken)
+        public virtual Response {|AZC0002:Get|}(CancellationToken cancellationToken)
         {
+            return null;
         }
     }
 }";
@@ -125,13 +133,14 @@ namespace RandomNamespace
 {
     public class SomeClient
     {
-        public virtual Task {|AZC0002:GetAsync|}(RequestContext context = default, string text = default)
+        public virtual Response {|AZC0002:GetAsync|}(RequestContext context = default, string text = default)
         {
             return null;
         }
 
-        public virtual void {|AZC0002:Get|}(RequestContext context = default, string text = default)
+        public virtual Response {|AZC0002:Get|}(RequestContext context = default, string text = default)
         {
+            return null;
         }
     }
 }";
@@ -152,13 +161,14 @@ namespace RandomNamespace
 {
     public class SomeClient
     {
-        public virtual Task {|AZC0002:GetAsync|}(CancellationToken cancellationToken = default, string text = default)
+        public virtual Response {|AZC0002:GetAsync|}(CancellationToken cancellationToken = default, string text = default)
         {
             return null;
         }
 
-        public virtual void {|AZC0002:Get|}(CancellationToken cancellationToken = default, string text = default)
+        public virtual Response {|AZC0002:Get|}(CancellationToken cancellationToken = default, string text = default)
         {
+            return null;
         }
     }
 }";

diff --git a/src/dotnet/Azure.ClientSdk.Analyzers/Azure.ClientSdk.Analyzers.Tests/AZC0003Tests.cs b/src/dotnet/Azure.ClientSdk.Analyzers/Azure.ClientSdk.Analyzers.Tests/AZC0003Tests.cs
@@ -13,20 +13,22 @@ public class AZC0003Tests
         public async Task AZC0003ProducedForNonVirtualMethods()
         {
             const string code = @"
+using Azure;
 using System.Threading;
 using System.Threading.Tasks;
 
 namespace RandomNamespace
 {
     public class SomeClient
     {
-        public Task {|AZC0003:GetAsync|](CancellationToken cancellationToken = default)
+        public Response {|AZC0003:GetAsync|](CancellationToken cancellationToken = default)
         {
             return null;
         }
 
-        public void {|AZC0003:Get|](CancellationToken cancellationToken = default)
+        public Response {|AZC0003:Get|](CancellationToken cancellationToken = default)
         {
+            return null;
         }
     }
 }";
@@ -95,4 +97,4 @@ await Verifier.CreateAnalyzer(code)
                 .RunAsync();
         }
     }
-}
+}