Resolve bug in Conversation Page (#8343)

Azure · May 29, 2024 · 0ee6250 · 0ee6250
1 parent a57c073
commit 0ee6250
Showing 1 changed file with 18 additions and 15 deletions.
diff --git a/src/dotnet/APIView/APIViewWeb/Pages/Assemblies/Conversation.cshtml b/src/dotnet/APIView/APIViewWeb/Pages/Assemblies/Conversation.cshtml
@@ -102,22 +102,25 @@
                                     {
                                         int indexA = Model.SampleLines.Count() - Math.Abs(revision.Key.sampleRevisionNumber - skipped);
                                         int indexB = int.Parse(thread.Comments.First().ElementId.Split("-").Last()) - 1;
-                                        @if (thread.Comments.Any())
-                                        {
-                                            var elementId = thread.LineId;
+                                        if (Model.SampleLines.Count() > indexA && Model.SampleLines.ElementAt(indexA).Count() > indexB)
+                                        {
+                                            @if (thread.Comments.Any())
+                                            {
+                                                var elementId = thread.LineId;
 
-                                            <tr class="code-line">
-                                                <td class="code p-2" style="word-break: break-all;">
-                                                    <a class="comment-url" asp-page="Samples"
-                                                        asp-route-id=@Model.Review.Id
-                                                        asp-route-revisionId=@thread.Comments.First().ElementId.Split("-").First()
-                                                        asp-fragment=@Uri.EscapeDataString(elementId)>
-                                                        @Html.Raw(Model.SampleLines.ElementAt(indexA).ElementAt(indexB))
-                                                    </a>
-                                                </td>
-                                            </tr>
-                                        }
-                                        <partial name="_CommentThreadPartial" model="@thread" />
+                                                <tr class="code-line">
+                                                    <td class="code p-2" style="word-break: break-all;">
+                                                        <a class="comment-url" asp-page="Samples"
+                                                            asp-route-id=@Model.Review.Id
+                                                            asp-route-revisionId=@thread.Comments.First().ElementId.Split("-").First()
+                                                            asp-fragment=@Uri.EscapeDataString(elementId)>
+                                                            @Html.Raw(Model.SampleLines.ElementAt(indexA).ElementAt(indexB))
+                                                        </a>
+                                                    </td>
+                                                </tr>
+                                            }
+                                            <partial name="_CommentThreadPartial" model="@thread" />
+                                        }
                                     }
                                 </table>
                             </div>