First cut at a Rust Eventhubs client. #1715
Conversation
LarryOsterman
requested review from
weshaggard,
heaths,
RickWinter and
JeffreyRichter
as code owners
|
I would appreciate any feedback on this PR - there are a couple of places I moved outside the amqp/eventhubs codebase, mostly to fix some wasm32 build issues related to tokio. |
|
@heaths, I would appreciate your feedback on this - it's very much a work in progress but it's a start. |
LarryOsterman
force-pushed
the
larryo/rust_eventhubs
branch
from
2c13ccd to
e2bd796
Compare
There was a problem hiding this comment.
I went through a lot of the code and hopefully gave enough feedback for now to chew on that should permeate throughout the code. Not all is blocking, and - as usual - I've tried to preface such things with "tip" or "nit". It's late on a Friday so we can talk some more Monday morning. Overall, it's looking pretty good. Mainly just some questions about (unnecessary?) complexity and a few non-idiomatic things. I wouldn't necessarily block on those if some issue(s) were filed to keep track of changes to make later.
No description provided.