Install sdist from pre-built package #9951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveenkuttappan
requested review from
danieljurek,
mitchdenny,
scbedd,
weshaggard and
zikalino
as code owners
scbedd
reviewed
Feb 21, 2020
|
|
||
|
|
||
| def discover_prebuilt_whl(whl_directory, setuppy_path): |
There was a problem hiding this comment.
nit: next time you make a pass through this. setup_py_path is easier to read than setuppy. It's not worth resetting the checks on this one though.
There was a problem hiding this comment.
Sure. I will make a note of it. Thanks
|
/azp run python - core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI builds wheel and sdist as part of build phase. Currently sdist test recreates sdist and install it and this causes conflict with depends test which needs to recreate the wheel before running depends test. Fix in this PR is to install sdist from pre-built wheel instead of recreating it.