Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require TLS for Key Vault challenge authentication #9457

Merged
merged 2 commits into from
Jan 14, 2020
Merged

Require TLS for Key Vault challenge authentication #9457

merged 2 commits into from
Jan 14, 2020

Conversation

chlowell
Copy link
Member

No description provided.

@chlowell chlowell added KeyVault Client This issue points to a problem in the data-plane of the library. labels Jan 14, 2020
@chlowell chlowell self-assigned this Jan 14, 2020
heaths
heaths approved these changes Jan 14, 2020
View reviewed changes
sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_shared/challenge_auth_policy.py
@@ -79,6 +79,7 @@ def __init__(self, credential, **kwargs):

def send(self, request):
# type: (PipelineRequest) -> HttpResponse
self._enforce_tls(request)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see this defined in the PR, but assuming it already was.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's inherited from a base class shared with the more general bearer token policy.

@chlowell chlowell merged commit 6cc1448 into Azure:master Jan 14, 2020
@chlowell chlowell deleted the enforce-tls branch January 14, 2020 18:39
chlowell added a commit that referenced this pull request Jan 15, 2020
@chlowell
revert corresponding changes to keyvault-*
3439b10 
note this doesn't revert #9457
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
686ff22 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
5ba6ba2 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
203e4f6 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
b46bbcd 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
0e1a7ca 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
f3cd97b 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
1452f88 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
4577416 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
db67777 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
b36e1b1 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
ff8f02a 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
f781037 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
9cb7486 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
1b477b4 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
acb4913 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
bdbc4d1 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
800fdb5 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
91288c1 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
9aac3dd 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
3e0ca13 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
9c4e1cd 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
1e37299 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
346f5a4 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
bad5661 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
d16322c 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
1864b82 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
626433a 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
6d5277b 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
5abe882 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
6a0d02d 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
546fcc9 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
0c08e9d 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
68e2ed3 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
97b4364 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
d73a59f 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
e2dfec8 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-python May 15, 2020
Generated from eabd724
d42b16a 
upgrade pipeline scripts version to 0.8.0 (#9457)

Co-authored-by: Jianye Xi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schaabs schaabs schaabs approved these changes

@heaths heaths heaths approved these changes

@sadasant sadasant Awaiting requested review from sadasant

@g2vinay g2vinay Awaiting requested review from g2vinay

@iscai-msft iscai-msft Awaiting requested review from iscai-msft

Assignees

@chlowell chlowell

Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chlowell @heaths @schaabs