-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align eventhub package folder names with package name #8813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weshaggard
requested review from
annatisch,
chlowell,
schaabs,
YijunXieMS and
yunhaoling
as code owners
November 22, 2019 20:54
Can one of the admins verify this patch? |
lmazuel
reviewed
Nov 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You get my point:
- Cross package should link to PyPI (checkpoint to eventhub, checkpoint to storage, etc.)
- Internal to package should be Github link
chlowell
reviewed
Nov 22, 2019
weshaggard
force-pushed
the
AlignEventhubsPkgAndFolder
branch
2 times, most recently
from
November 23, 2019 00:46
1da4cb0
to
48b6f72
Compare
/azp run python - eventhub - ci |
Pull request contains merge conflicts. |
praveenkuttappan
force-pushed
the
AlignEventhubsPkgAndFolder
branch
from
December 2, 2019 07:41
48b6f72
to
a1d819f
Compare
weshaggard
force-pushed
the
AlignEventhubsPkgAndFolder
branch
2 times, most recently
from
December 2, 2019 22:28
2eaf969
to
ae7dbfa
Compare
annatisch
previously approved these changes
Dec 3, 2019
weshaggard
force-pushed
the
AlignEventhubsPkgAndFolder
branch
from
December 3, 2019 16:30
ae7dbfa
to
f0ad31e
Compare
annatisch
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was making changes to some of the README.md files I also changes their links to be relative instead of pointing at master contributing to Azure/azure-sdk#798.
PTAL @lmazuel