Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align eventhub package folder names with package name #8813

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

weshaggard
Copy link
Member

While I was making changes to some of the README.md files I also changes their links to be relative instead of pointing at master contributing to Azure/azure-sdk#798.

PTAL @lmazuel

@adxsdk6
Copy link

adxsdk6 commented Nov 22, 2019

Can one of the admins verify this patch?

Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You get my point:

  • Cross package should link to PyPI (checkpoint to eventhub, checkpoint to storage, etc.)
  • Internal to package should be Github link

@weshaggard weshaggard force-pushed the AlignEventhubsPkgAndFolder branch 2 times, most recently from 1da4cb0 to 48b6f72 Compare November 23, 2019 00:46
@praveenkuttappan
Copy link
Member

/azp run python - eventhub - ci

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@praveenkuttappan praveenkuttappan force-pushed the AlignEventhubsPkgAndFolder branch from 48b6f72 to a1d819f Compare December 2, 2019 07:41
@weshaggard weshaggard force-pushed the AlignEventhubsPkgAndFolder branch 2 times, most recently from 2eaf969 to ae7dbfa Compare December 2, 2019 22:28
annatisch
annatisch previously approved these changes Dec 3, 2019
@weshaggard weshaggard merged commit 2b8a6ed into Azure:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants