[Storage] File SDK rename #8164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annatisch
added
Storage
|
Can one of the admins verify this patch? |
sdk/storage/azure-storage-file-share/azure/storage/fileshare/_shared/models.py
Show resolved
Hide resolved
|
/azp run python - storage - ci |
|
Pull request contains merge conflicts. |
|
/azp run python - storage - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This reverts commit 5702cb1.
annatisch
requested review from
danieljurek,
mitchdenny,
rakshith91 and
scbedd
as code owners
lmazuel
approved these changes
Oct 24, 2019
rakshith91
approved these changes
Oct 24, 2019
xiafu-msft
reviewed
Oct 24, 2019
sdk/storage/azure-storage-blob/azure/storage/blob/_shared/base_client.py
Show resolved
Hide resolved
xiafu-msft
approved these changes
Oct 24, 2019
johanste
reviewed
Oct 24, 2019
johanste
reviewed
Oct 24, 2019
johanste
reviewed
Oct 24, 2019
| this client represents interaction with a specific file (which need not exist yet). It provides operations to | ||
| upload, download, create, delete, and copy a file. | ||
|
|
||
| For details on path naming restrictions, see [Naming and Referencing Shares, Directories, Files, and Metadata](https://docs.microsoft.com/rest/api/storageservices/naming-and-referencing-shares--directories--files--and-metadata). | ||
|
|
||
| ## Examples | ||
| The following sections provide several code snippets covering some of the most common Storage File tasks, including: | ||
| The following sections provide several code snippets covering some of the most common Storage File Share tasks, including: |
There was a problem hiding this comment.
Should the description of the examples include the term "Share"? Or should we stay true to the service name? What are the other languages doing here?
There was a problem hiding this comment.
I've tried to insert the name "Share" when discussing the service, to try and connect with the new "ShareServiceClient" naming, which doesn't contain the term "File" at all....
Will ask around re what other languages are doing.
There was a problem hiding this comment.
Confirmed that in the portal this is now referred to as "file shares" service.
|
Give me one minute to double check the name again ^_^ |
kristapratico
approved these changes
Oct 25, 2019
fengzhou-msft
pushed a commit
that referenced
this pull request
Nov 5, 2019
* Renamed package dir * Renamed namespace dir * Some packaging updates * Renamed ShareServiceClient * Renamed _share_service_client * Renamed ShareDirectoryClient * Renamed ShareFileClient * Updated namespace references * Some fixes * Other repo components * Synced shared models * More repo components * Pylint fix * Updated user agent * Unique share names * Revert "Unique share names" This reverts commit 5702cb1. * Classmethod return types * Updated release notes * Merge fix * Updated namespace references * Updated readme * Manual sample merge * Updated samples * Merge fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #8140