Eventhubs preview4 merge to master #7605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* runtime metric init commit * evenhubts-runtime-metric implementation * Update code, and test and docstring * Add example code * Update property name * Update name to last enqueued event properties
* Remove iothub/link-redirect related code * Remove self._running from consumer and producer * Remove IoT related params "operation" and "device" * Remove exception from close() * add iterator long running test * small bug fix * small bug fix * Fix connection properties bug and format * Changed product to azure-eventhub in user agent * Fix a type hint * Improve stress script * Print to console configurable * small changes * Disable tracking last enqueued event properties for uamqp 1.2.2 * use different consumer group * fix an issue about consumer group * fix an issue about consumer group * Fix a get_properties bug
* performance improvement * batch offset * Review feedback * Remove lazy parse in EventData * Add annotation assertions
|
Can one of the admins verify this patch? |
added 2 commits
October 3, 2019 18:25
|
/azp run python - eventhubs - tests |
|
No pipelines are associated with this pull request. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - eventhubs - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - eventhubs - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
danieljurek
reviewed
Oct 4, 2019
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
* Update docs * Update iothub related description * Docs update * Small fix * Small fix * revert setup.py
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
yunhaoling
approved these changes
Oct 5, 2019
| self._error = EventHubError("This receive handler is now closed.") | ||
| if self._handler: | ||
| await self._handler.close_async() | ||
| await super(EventHubConsumer, self).close() |
There was a problem hiding this comment.
We probably could remove this close, as it's simply calling parent's close.
but not this time, could be in the next release
| @@ -270,4 +251,4 @@ def _on_outcome(self, outcome, condition): | |||
| :caption: Close down the handler. | |||
|
|
|||
| """ | |||
| await super(EventHubProducer, self).close(exception) | |||
| await super(EventHubProducer, self).close() | |||
There was a problem hiding this comment.
same to the close comment above
| source = Source(self._source) | ||
| if self._offset is not None: | ||
| source.set_filter(self._offset._selector()) # pylint:disable=protected-access | ||
|
|
||
| if StrictVersion(uamqp.__version__) < StrictVersion("1.2.3"): # backward compatible until uamqp 1.2.3 released | ||
| desired_capabilities = {} |
There was a problem hiding this comment.
same to suggestion of logging a warning above
| @@ -281,4 +262,4 @@ def close(self, exception=None): # pylint:disable=useless-super-delegation | |||
| :caption: Close down the handler. | |||
|
|
|||
| """ | |||
| super(EventHubProducer, self).close(exception) | |||
| super(EventHubProducer, self).close() | |||
There was a problem hiding this comment.
same to the close comment above
iscai-msft
pushed a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Oct 7, 2019
* [EventHubs] Eventhubs runtime metric (Azure#7431) * runtime metric init commit * evenhubts-runtime-metric implementation * Update code, and test and docstring * Add example code * Update property name * Update name to last enqueued event properties * Eventhubs remove iot and linkredirect (Azure#7450) * Remove iothub/link-redirect related code * Remove self._running from consumer and producer * Remove IoT related params "operation" and "device" * Remove exception from close() * add iterator long running test * small bug fix * small bug fix * Fix connection properties bug and format * Changed product to azure-eventhub in user agent * Fix a type hint * Improve stress script * Print to console configurable * small changes * Disable tracking last enqueued event properties for uamqp 1.2.2 * use different consumer group * fix an issue about consumer group * fix an issue about consumer group * Fix a get_properties bug * [EventHubs] Performance improvement (Azure#7533) * performance improvement * batch offset * Review feedback * Remove lazy parse in EventData * Add annotation assertions * Small fix for missing annotation initialization (Azure#7575) * Python EventHubs test code revamp (Azure#7594) * fix pylint error * fix mypy error * fix for 2.7 * fix for 2.7 * Sleep 300 seconds to test reconnect * Remove Pypy from eventhub live test * Remove Pypy from eventhub live test * Add "Matrix:" * Fix bug passing timeout in seconds to uamqp * update checkpointstore HISTORY * [EventHubs] Update documentations (Azure#7603) * Update docs * Update iothub related description * Docs update * Small fix * Small fix * revert setup.py
iscai-msft
added a commit
that referenced
this pull request
Oct 7, 2019
* switched vault_url to vault_endpoint across key vault * moved enabled and tags to kwargs * changed the name parameter for get_policy and update_policy to certificate_name * updated changelog * [Core] Updated release notes (#7627) * Core doc fix (#7638) * Fix azure-core examples * Fix azure-core Readme * Simplify doc * Kill common.py file * Remove tracing.ext * update app config doc (#7618) * update app config doc * move match_condition to internal * [AutoPR] netapp/resource-manager (#7092) * Generated from 34d744550227bee7b380604d38fc1de6c9af6397 (#7089) Update netapp.json * changelog for netapp * ANF-374 update for R5 RP version 2019-07-01 API * ANF-374 update for R5 RP version 2019-07-01 API (#7460) * ANF-374 update for R5 RP version 2019-07-01 API * ANF-374 update for R5 RP version 2019-07-01 API * ANF-374 update for R5 RP version 2019-07-01 API * extending pypy timeout. (#7640) * Eventhubs preview4 merge to master (#7605) * [EventHubs] Eventhubs runtime metric (#7431) * runtime metric init commit * evenhubts-runtime-metric implementation * Update code, and test and docstring * Add example code * Update property name * Update name to last enqueued event properties * Eventhubs remove iot and linkredirect (#7450) * Remove iothub/link-redirect related code * Remove self._running from consumer and producer * Remove IoT related params "operation" and "device" * Remove exception from close() * add iterator long running test * small bug fix * small bug fix * Fix connection properties bug and format * Changed product to azure-eventhub in user agent * Fix a type hint * Improve stress script * Print to console configurable * small changes * Disable tracking last enqueued event properties for uamqp 1.2.2 * use different consumer group * fix an issue about consumer group * fix an issue about consumer group * Fix a get_properties bug * [EventHubs] Performance improvement (#7533) * performance improvement * batch offset * Review feedback * Remove lazy parse in EventData * Add annotation assertions * Small fix for missing annotation initialization (#7575) * Python EventHubs test code revamp (#7594) * fix pylint error * fix mypy error * fix for 2.7 * fix for 2.7 * Sleep 300 seconds to test reconnect * Remove Pypy from eventhub live test * Remove Pypy from eventhub live test * Add "Matrix:" * Fix bug passing timeout in seconds to uamqp * update checkpointstore HISTORY * [EventHubs] Update documentations (#7603) * Update docs * Update iothub related description * Docs update * Small fix * Small fix * revert setup.py * Resolve Global Install Errors (#7642) * swapping all dev_requirements to leverage the non-develop mode. opencensus-tracing will fail if azure-core is installed in dev mode. all the rest of the tests are ok with using non-dev, so this seems to be a good compromise * Setup core for unified pipelines. (#7577) * Setup core for unified pipelines. * Added open census to the core pipeline (can be released independently). * Publish the packages artifact. (#7643) * Enable template for unified templates. (#7644) * Setup template for UP. * Fixed service directory. * ensure error_map is used consistently and correctly (#7637) * switched vault_url to vault_endpoint across key vault * ran black on keyvault * reverted <<<HEAD additions to code * got rid of black changes that broke python 3.5
YijunXieMS
added a commit
to YijunXieMS/azure-sdk-for-python
that referenced
this pull request
Oct 9, 2019
* [EventHubs] Eventhubs runtime metric (Azure#7431) * runtime metric init commit * evenhubts-runtime-metric implementation * Update code, and test and docstring * Add example code * Update property name * Update name to last enqueued event properties * Eventhubs remove iot and linkredirect (Azure#7450) * Remove iothub/link-redirect related code * Remove self._running from consumer and producer * Remove IoT related params "operation" and "device" * Remove exception from close() * add iterator long running test * small bug fix * small bug fix * Fix connection properties bug and format * Changed product to azure-eventhub in user agent * Fix a type hint * Improve stress script * Print to console configurable * small changes * Disable tracking last enqueued event properties for uamqp 1.2.2 * use different consumer group * fix an issue about consumer group * fix an issue about consumer group * Fix a get_properties bug * [EventHubs] Performance improvement (Azure#7533) * performance improvement * batch offset * Review feedback * Remove lazy parse in EventData * Add annotation assertions * Small fix for missing annotation initialization (Azure#7575) * Python EventHubs test code revamp (Azure#7594) * fix pylint error * fix mypy error * fix for 2.7 * fix for 2.7 * Sleep 300 seconds to test reconnect * Remove Pypy from eventhub live test * Remove Pypy from eventhub live test * Add "Matrix:" * Fix bug passing timeout in seconds to uamqp * update checkpointstore HISTORY * [EventHubs] Update documentations (Azure#7603) * Update docs * Update iothub related description * Docs update * Small fix * Small fix * revert setup.py
YijunXieMS
pushed a commit
to YijunXieMS/azure-sdk-for-python
that referenced
this pull request
Oct 9, 2019
* switched vault_url to vault_endpoint across key vault * moved enabled and tags to kwargs * changed the name parameter for get_policy and update_policy to certificate_name * updated changelog * [Core] Updated release notes (Azure#7627) * Core doc fix (Azure#7638) * Fix azure-core examples * Fix azure-core Readme * Simplify doc * Kill common.py file * Remove tracing.ext * update app config doc (Azure#7618) * update app config doc * move match_condition to internal * [AutoPR] netapp/resource-manager (Azure#7092) * Generated from 34d744550227bee7b380604d38fc1de6c9af6397 (Azure#7089) Update netapp.json * changelog for netapp * ANF-374 update for R5 RP version 2019-07-01 API * ANF-374 update for R5 RP version 2019-07-01 API (Azure#7460) * ANF-374 update for R5 RP version 2019-07-01 API * ANF-374 update for R5 RP version 2019-07-01 API * ANF-374 update for R5 RP version 2019-07-01 API * extending pypy timeout. (Azure#7640) * Eventhubs preview4 merge to master (Azure#7605) * [EventHubs] Eventhubs runtime metric (Azure#7431) * runtime metric init commit * evenhubts-runtime-metric implementation * Update code, and test and docstring * Add example code * Update property name * Update name to last enqueued event properties * Eventhubs remove iot and linkredirect (Azure#7450) * Remove iothub/link-redirect related code * Remove self._running from consumer and producer * Remove IoT related params "operation" and "device" * Remove exception from close() * add iterator long running test * small bug fix * small bug fix * Fix connection properties bug and format * Changed product to azure-eventhub in user agent * Fix a type hint * Improve stress script * Print to console configurable * small changes * Disable tracking last enqueued event properties for uamqp 1.2.2 * use different consumer group * fix an issue about consumer group * fix an issue about consumer group * Fix a get_properties bug * [EventHubs] Performance improvement (Azure#7533) * performance improvement * batch offset * Review feedback * Remove lazy parse in EventData * Add annotation assertions * Small fix for missing annotation initialization (Azure#7575) * Python EventHubs test code revamp (Azure#7594) * fix pylint error * fix mypy error * fix for 2.7 * fix for 2.7 * Sleep 300 seconds to test reconnect * Remove Pypy from eventhub live test * Remove Pypy from eventhub live test * Add "Matrix:" * Fix bug passing timeout in seconds to uamqp * update checkpointstore HISTORY * [EventHubs] Update documentations (Azure#7603) * Update docs * Update iothub related description * Docs update * Small fix * Small fix * revert setup.py * Resolve Global Install Errors (Azure#7642) * swapping all dev_requirements to leverage the non-develop mode. opencensus-tracing will fail if azure-core is installed in dev mode. all the rest of the tests are ok with using non-dev, so this seems to be a good compromise * Setup core for unified pipelines. (Azure#7577) * Setup core for unified pipelines. * Added open census to the core pipeline (can be released independently). * Publish the packages artifact. (Azure#7643) * Enable template for unified templates. (Azure#7644) * Setup template for UP. * Fixed service directory. * ensure error_map is used consistently and correctly (Azure#7637) * switched vault_url to vault_endpoint across key vault * ran black on keyvault * reverted <<<HEAD additions to code * got rid of black changes that broke python 3.5
kristapratico
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Oct 9, 2019
* [EventHubs] Eventhubs runtime metric (Azure#7431) * runtime metric init commit * evenhubts-runtime-metric implementation * Update code, and test and docstring * Add example code * Update property name * Update name to last enqueued event properties * Eventhubs remove iot and linkredirect (Azure#7450) * Remove iothub/link-redirect related code * Remove self._running from consumer and producer * Remove IoT related params "operation" and "device" * Remove exception from close() * add iterator long running test * small bug fix * small bug fix * Fix connection properties bug and format * Changed product to azure-eventhub in user agent * Fix a type hint * Improve stress script * Print to console configurable * small changes * Disable tracking last enqueued event properties for uamqp 1.2.2 * use different consumer group * fix an issue about consumer group * fix an issue about consumer group * Fix a get_properties bug * [EventHubs] Performance improvement (Azure#7533) * performance improvement * batch offset * Review feedback * Remove lazy parse in EventData * Add annotation assertions * Small fix for missing annotation initialization (Azure#7575) * Python EventHubs test code revamp (Azure#7594) * fix pylint error * fix mypy error * fix for 2.7 * fix for 2.7 * Sleep 300 seconds to test reconnect * Remove Pypy from eventhub live test * Remove Pypy from eventhub live test * Add "Matrix:" * Fix bug passing timeout in seconds to uamqp * update checkpointstore HISTORY * [EventHubs] Update documentations (Azure#7603) * Update docs * Update iothub related description * Docs update * Small fix * Small fix * revert setup.py
kristapratico
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Oct 9, 2019
* switched vault_url to vault_endpoint across key vault * moved enabled and tags to kwargs * changed the name parameter for get_policy and update_policy to certificate_name * updated changelog * [Core] Updated release notes (Azure#7627) * Core doc fix (Azure#7638) * Fix azure-core examples * Fix azure-core Readme * Simplify doc * Kill common.py file * Remove tracing.ext * update app config doc (Azure#7618) * update app config doc * move match_condition to internal * [AutoPR] netapp/resource-manager (Azure#7092) * Generated from 34d744550227bee7b380604d38fc1de6c9af6397 (Azure#7089) Update netapp.json * changelog for netapp * ANF-374 update for R5 RP version 2019-07-01 API * ANF-374 update for R5 RP version 2019-07-01 API (Azure#7460) * ANF-374 update for R5 RP version 2019-07-01 API * ANF-374 update for R5 RP version 2019-07-01 API * ANF-374 update for R5 RP version 2019-07-01 API * extending pypy timeout. (Azure#7640) * Eventhubs preview4 merge to master (Azure#7605) * [EventHubs] Eventhubs runtime metric (Azure#7431) * runtime metric init commit * evenhubts-runtime-metric implementation * Update code, and test and docstring * Add example code * Update property name * Update name to last enqueued event properties * Eventhubs remove iot and linkredirect (Azure#7450) * Remove iothub/link-redirect related code * Remove self._running from consumer and producer * Remove IoT related params "operation" and "device" * Remove exception from close() * add iterator long running test * small bug fix * small bug fix * Fix connection properties bug and format * Changed product to azure-eventhub in user agent * Fix a type hint * Improve stress script * Print to console configurable * small changes * Disable tracking last enqueued event properties for uamqp 1.2.2 * use different consumer group * fix an issue about consumer group * fix an issue about consumer group * Fix a get_properties bug * [EventHubs] Performance improvement (Azure#7533) * performance improvement * batch offset * Review feedback * Remove lazy parse in EventData * Add annotation assertions * Small fix for missing annotation initialization (Azure#7575) * Python EventHubs test code revamp (Azure#7594) * fix pylint error * fix mypy error * fix for 2.7 * fix for 2.7 * Sleep 300 seconds to test reconnect * Remove Pypy from eventhub live test * Remove Pypy from eventhub live test * Add "Matrix:" * Fix bug passing timeout in seconds to uamqp * update checkpointstore HISTORY * [EventHubs] Update documentations (Azure#7603) * Update docs * Update iothub related description * Docs update * Small fix * Small fix * revert setup.py * Resolve Global Install Errors (Azure#7642) * swapping all dev_requirements to leverage the non-develop mode. opencensus-tracing will fail if azure-core is installed in dev mode. all the rest of the tests are ok with using non-dev, so this seems to be a good compromise * Setup core for unified pipelines. (Azure#7577) * Setup core for unified pipelines. * Added open census to the core pipeline (can be released independently). * Publish the packages artifact. (Azure#7643) * Enable template for unified templates. (Azure#7644) * Setup template for UP. * Fixed service directory. * ensure error_map is used consistently and correctly (Azure#7637) * switched vault_url to vault_endpoint across key vault * ran black on keyvault * reverted <<<HEAD additions to code * got rid of black changes that broke python 3.5
fengzhou-msft
pushed a commit
that referenced
this pull request
Nov 5, 2019
* [EventHubs] Eventhubs runtime metric (#7431) * runtime metric init commit * evenhubts-runtime-metric implementation * Update code, and test and docstring * Add example code * Update property name * Update name to last enqueued event properties * Eventhubs remove iot and linkredirect (#7450) * Remove iothub/link-redirect related code * Remove self._running from consumer and producer * Remove IoT related params "operation" and "device" * Remove exception from close() * add iterator long running test * small bug fix * small bug fix * Fix connection properties bug and format * Changed product to azure-eventhub in user agent * Fix a type hint * Improve stress script * Print to console configurable * small changes * Disable tracking last enqueued event properties for uamqp 1.2.2 * use different consumer group * fix an issue about consumer group * fix an issue about consumer group * Fix a get_properties bug * [EventHubs] Performance improvement (#7533) * performance improvement * batch offset * Review feedback * Remove lazy parse in EventData * Add annotation assertions * Small fix for missing annotation initialization (#7575) * Python EventHubs test code revamp (#7594) * fix pylint error * fix mypy error * fix for 2.7 * fix for 2.7 * Sleep 300 seconds to test reconnect * Remove Pypy from eventhub live test * Remove Pypy from eventhub live test * Add "Matrix:" * Fix bug passing timeout in seconds to uamqp * update checkpointstore HISTORY * [EventHubs] Update documentations (#7603) * Update docs * Update iothub related description * Docs update * Small fix * Small fix * revert setup.py
fengzhou-msft
pushed a commit
that referenced
this pull request
Nov 5, 2019
* switched vault_url to vault_endpoint across key vault * moved enabled and tags to kwargs * changed the name parameter for get_policy and update_policy to certificate_name * updated changelog * [Core] Updated release notes (#7627) * Core doc fix (#7638) * Fix azure-core examples * Fix azure-core Readme * Simplify doc * Kill common.py file * Remove tracing.ext * update app config doc (#7618) * update app config doc * move match_condition to internal * [AutoPR] netapp/resource-manager (#7092) * Generated from 34d744550227bee7b380604d38fc1de6c9af6397 (#7089) Update netapp.json * changelog for netapp * ANF-374 update for R5 RP version 2019-07-01 API * ANF-374 update for R5 RP version 2019-07-01 API (#7460) * ANF-374 update for R5 RP version 2019-07-01 API * ANF-374 update for R5 RP version 2019-07-01 API * ANF-374 update for R5 RP version 2019-07-01 API * extending pypy timeout. (#7640) * Eventhubs preview4 merge to master (#7605) * [EventHubs] Eventhubs runtime metric (#7431) * runtime metric init commit * evenhubts-runtime-metric implementation * Update code, and test and docstring * Add example code * Update property name * Update name to last enqueued event properties * Eventhubs remove iot and linkredirect (#7450) * Remove iothub/link-redirect related code * Remove self._running from consumer and producer * Remove IoT related params "operation" and "device" * Remove exception from close() * add iterator long running test * small bug fix * small bug fix * Fix connection properties bug and format * Changed product to azure-eventhub in user agent * Fix a type hint * Improve stress script * Print to console configurable * small changes * Disable tracking last enqueued event properties for uamqp 1.2.2 * use different consumer group * fix an issue about consumer group * fix an issue about consumer group * Fix a get_properties bug * [EventHubs] Performance improvement (#7533) * performance improvement * batch offset * Review feedback * Remove lazy parse in EventData * Add annotation assertions * Small fix for missing annotation initialization (#7575) * Python EventHubs test code revamp (#7594) * fix pylint error * fix mypy error * fix for 2.7 * fix for 2.7 * Sleep 300 seconds to test reconnect * Remove Pypy from eventhub live test * Remove Pypy from eventhub live test * Add "Matrix:" * Fix bug passing timeout in seconds to uamqp * update checkpointstore HISTORY * [EventHubs] Update documentations (#7603) * Update docs * Update iothub related description * Docs update * Small fix * Small fix * revert setup.py * Resolve Global Install Errors (#7642) * swapping all dev_requirements to leverage the non-develop mode. opencensus-tracing will fail if azure-core is installed in dev mode. all the rest of the tests are ok with using non-dev, so this seems to be a good compromise * Setup core for unified pipelines. (#7577) * Setup core for unified pipelines. * Added open census to the core pipeline (can be released independently). * Publish the packages artifact. (#7643) * Enable template for unified templates. (#7644) * Setup template for UP. * Fixed service directory. * ensure error_map is used consistently and correctly (#7637) * switched vault_url to vault_endpoint across key vault * ran black on keyvault * reverted <<<HEAD additions to code * got rid of black changes that broke python 3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All code has been reviewed when merging to feature branch eventhubs_preview4.
This PR is to merge the feature branch to master