-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azure-keyvault-nspkg #7125
azure-keyvault-nspkg #7125
Changes from 5 commits
d24c1e2
58de772
297d806
d92eca5
a83d3c4
779826a
1205a6a
1d56f45
e8c2b7b
7756ffd
6a22c80
1805d50
42029f9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,7 +25,7 @@ | |
"mgmt", | ||
"azure-cognitiveservices", | ||
"azure-servicefabric", | ||
"azure-nspkg", | ||
"nspkg" | ||
] | ||
|
||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,7 @@ | |
-e ../../../tools/azure-devtools | ||
-e ../../../tools/azure-sdk-tools | ||
-e ../../identity/azure-identity | ||
-e ../azure-keyvault-nspkg | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That should not be necessary for dev, since all init will contain pkgutil line, nspkg is really interesting only for Python 2 correct support There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. At least it won't be necessary once the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It was necessary to unblock CI, which was failing to install the dependency (it hasn't been published). |
||
-e ../azure-mgmt-keyvault | ||
aiohttp>=3.0; python_version >= '3.5' | ||
pytest-asyncio>=0.8.0; python_version > '3.4' |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
include *.md | ||
include azure/__init__.py | ||
include azure/keyvault/__init__.py | ||
chlowell marked this conversation as resolved.
Show resolved
Hide resolved
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
# Microsoft Azure SDK for Python | ||
|
||
This is the Microsoft Azure Key Vault namespace package. It isn't intended to | ||
be installed directly. Key Vault client libraries are located elsewhere: | ||
- [`azure-keyvault-certificates`](https://github.com/Azure/azure-sdk-for-python/tree/master/sdk/keyvault/azure-keyvault-certificates) | ||
- [`azure-keyvault-keys`](https://github.com/Azure/azure-sdk-for-python/tree/master/sdk/keyvault/azure-keyvault-keys) | ||
- [`azure-keyvault-secrets`](https://github.com/Azure/azure-sdk-for-python/tree/master/sdk/keyvault/azure-keyvault-secrets) | ||
|
||
This is a Python 2 package only. Python 3.x libraries will use | ||
[`PEP420`](https://www.python.org/dev/peps/pep-0420/) as namespace package | ||
strategy. To avoid issues with package servers that don't support | ||
`python_requires`, a Python 3 package is installed but is empty. | ||
|
||
This package provides the necessary files for other packages to extend the | ||
`azure` namespace. | ||
|
||
![Impressions](https://azure-sdk-impressions.azurewebsites.net/api/impressions/azure-sdk-for-python%2Fsdk%2Fkeyvault%2Fazure-keyvault-nspkg%2FFREADME.png) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
# ------------------------------------ | ||
# Copyright (c) Microsoft Corporation. | ||
# Licensed under the MIT License. | ||
# ------------------------------------ | ||
# pylint:disable=missing-docstring | ||
__path__ = __import__("pkgutil").extend_path(__path__, __name__) # type: ignore |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
# ------------------------------------ | ||
# Copyright (c) Microsoft Corporation. | ||
# Licensed under the MIT License. | ||
# ------------------------------------ | ||
# pylint:disable=missing-docstring | ||
__path__ = __import__("pkgutil").extend_path(__path__, __name__) # type: ignore |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
[bdist_wheel] | ||
universal=1 | ||
lmazuel marked this conversation as resolved.
Show resolved
Hide resolved
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
#!/usr/bin/env python | ||
|
||
# ------------------------------------ | ||
# Copyright (c) Microsoft Corporation. | ||
# Licensed under the MIT License. | ||
# ------------------------------------ | ||
import sys | ||
from setuptools import setup | ||
|
||
# azure v0.x is not compatible with this package | ||
# azure v0.x used to have a __version__ attribute (newer versions don't) | ||
try: | ||
import azure | ||
|
||
try: | ||
ver = azure.__version__ | ||
raise Exception( | ||
"This package is incompatible with azure=={}. ".format(ver) + 'Uninstall it with "pip uninstall azure".' | ||
) | ||
except AttributeError: | ||
pass | ||
except ImportError: | ||
pass | ||
|
||
PACKAGES = [] | ||
# Do an empty package on Python 3 and not python_requires, since not everybody is ready | ||
# https://github.com/Azure/azure-sdk-for-python/issues/3447 | ||
# https://github.com/Azure/azure-sdk-for-python/issues/3481 | ||
if sys.version_info[0] < 3: | ||
PACKAGES = ["azure.keyvault"] | ||
|
||
setup( | ||
name="azure-keyvault-nspkg", | ||
version="3.0.0", | ||
chlowell marked this conversation as resolved.
Show resolved
Hide resolved
|
||
description="Microsoft Azure Key Vault Namespace Package [Internal]", | ||
long_description=open("README.md", "r").read(), | ||
long_description_content_type="text/markdown", | ||
license="MIT License", | ||
author="Microsoft Corporation", | ||
author_email="[email protected]", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this really the correct author email? |
||
url="https://github.com/Azure/azure-sdk-for-python/tree/master/sdk/keyvault", | ||
classifiers=[ | ||
"Development Status :: 5 - Production/Stable", | ||
"Programming Language :: Python", | ||
"Programming Language :: Python :: 2", | ||
"Programming Language :: Python :: 2.7", | ||
"Programming Language :: Python :: 3", | ||
"Programming Language :: Python :: 3.4", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 3.4? |
||
"Programming Language :: Python :: 3.5", | ||
"Programming Language :: Python :: 3.6", | ||
"Programming Language :: Python :: 3.7", | ||
"License :: OSI Approved :: MIT License", | ||
], | ||
zip_safe=False, | ||
packages=PACKAGES, | ||
install_requires=["azure-nspkg>=3.0.0"], | ||
) |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -77,6 +77,7 @@ azure-mgmt-subscription~=0.2.0 | |
azure-mgmt-trafficmanager~=0.50.0 | ||
azure-mgmt-web~=0.35.0 | ||
azure-nspkg | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you need to remove this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't believe so. |
||
azure-keyvault-nspkg | ||
azure-security-nspkg | ||
azure-servicebus~=0.21.1 | ||
azure-servicefabric~=6.3.0.0 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not azure-keyvault-nspkg?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. This allows any package with "nspkg" in its name to pass CI despite having no tests.