[Core] Config not required for pipeline client #6972
Conversation
|
Can one of the admins verify this patch? |
|
This seems fine though I am curious what are all the use cases? When would a Pipeline vs a config vs a list of policies be used? |
|
Thanks @bryevdv! |
| @@ -59,7 +59,7 @@ class PipelineClient(PipelineClientBase): | |||
| Builds a Pipeline client. | |||
|
|
|||
| :param str base_url: URL for the request. | |||
| :param config: Service configuration. This is a required parameter. | |||
| :param config: Service configuration. This is a required unless pipeline or policies are given separately. | |||
| @@ -80,10 +80,8 @@ class PipelineClient(PipelineClientBase): | |||
| :caption: Builds the pipeline client. | |||
| """ | |||
|
|
|||
| def __init__(self, base_url, config, **kwargs): | |||
| def __init__(self, base_url, config=None, **kwargs): | |||
There was a problem hiding this comment.
Should we put config into kwargs?
| DistributedTracingPolicy(), | ||
| config.logging_policy, |
There was a problem hiding this comment.
Maybe we should add proxy policy as well.
| @@ -106,6 +104,8 @@ def _build_pipeline(self, config, **kwargs): # pylint: disable=no-self-use | |||
| policies = kwargs.get('policies') | |||
|
|
|||
| if policies is None: # [] is a valid policy list | |||
| if config is None: | |||
| raise ValueError("No config or policies supplied.") | |||
There was a problem hiding this comment.
Why not if config is None, give a default one?
|
This PR isn't needed for Preview3 - so going to shelve for now. |
|
Picked up in PR #7734 |
No description provided.