Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[storage] Readme tweaks #6697

Merged
merged 3 commits into from
Aug 6, 2019
Merged

[storage] Readme tweaks #6697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0647f11
Fix for queue models
annatisch Aug 6, 2019
2ab6c2e
Docs cleanups
annatisch Aug 6, 2019
bdcb007
Merge remote-tracking branch 'upstream/storage-preview2' into storage…
annatisch Aug 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion sdk/storage/azure-storage-blob/HISTORY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@
**Dependency updates**
- Adopted [azure-core](https://pypi.org/project/azure-core/) 1.0.0b2
- If you later want to revert to azure-storage-blob 12.0.0b1, or another Azure SDK
library requiring azure-core 1.0.0b1, you'll need to `pip uninstall azure-core`
library requiring azure-core 1.0.0b1, you must explicitly install azure-core
1.0.0b1 as well. For example:

`pip install azure-core==1.0.0b1 azure-storage-blob==12.0.0b1`

**Fixes and improvements**
- Fix for SAS URL encoding (#6500)
Expand Down
3 changes: 2 additions & 1 deletion sdk/storage/azure-storage-blob/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,8 @@ from azure.storage.blob import BlobClient
blob = BlobClient.from_connection_string("my_connection_string", container="mycontainer", blob="my_blob")

with open("./BlockDestination.txt", "wb") as my_blob:
my_blob.writelines(blob.download_blob())
blob_data = blob.download_blob()
my_blob.writelines(blob_data.content_as_bytes())
```

### Enumerating blobs
Expand Down
3 changes: 0 additions & 3 deletions sdk/storage/azure-storage-blob/tests/test_block_blob_sync_copy_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,6 @@ def setUp(self):
self.source_blob_data = self.get_random_bytes(SOURCE_BLOB_SIZE)

blob = self.bsc.get_blob_client(self.container_name, self.source_blob_name)
if not self.is_playback():
self.bsc.create_container(self.container_name)
blob.upload_blob(self.source_blob_data)

# generate a SAS so that it is accessible with a URL
sas_token = blob.generate_shared_access_signature(
Expand Down
5 changes: 4 additions & 1 deletion sdk/storage/azure-storage-file/HISTORY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,10 @@
**Dependency updates**
- Adopted [azure-core](https://pypi.org/project/azure-core/) 1.0.0b2
- If you later want to revert to azure-storage-file 12.0.0b1, or another Azure SDK
library requiring azure-core 1.0.0b1, you'll need to `pip uninstall azure-core`
library requiring azure-core 1.0.0b1, you must explicitly install azure-core
1.0.0b1 as well. For example:

`pip install azure-core==1.0.0b1 azure-storage-file==12.0.0b1`

**Fixes and improvements**
- Fix for closing file handles - continuation token was not being passed to subsequent calls.
Expand Down
4 changes: 2 additions & 2 deletions sdk/storage/azure-storage-file/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,10 @@ Upload a file to the share
```python
from azure.storage.file import FileClient

file = FileClient.from_connection_string("my_connection_string", share="share", file_path="myfile")
file_client = FileClient.from_connection_string("my_connection_string", share="share", file_path="myfile")

with open("./SampleSource.txt", "rb") as source_file:
file.upload_file(source_file)
file_client.upload_file(source_file)
```

## Troubleshooting
Expand Down
5 changes: 4 additions & 1 deletion sdk/storage/azure-storage-queue/HISTORY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@
**Dependency updates**
- Adopted [azure-core](https://pypi.org/project/azure-core/) 1.0.0b2
- If you later want to revert to azure-storage-queue 12.0.0b1, or another Azure SDK
library requiring azure-core 1.0.0b1, you'll need to `pip uninstall azure-core`
library requiring azure-core 1.0.0b1, you must explicitly install azure-core
1.0.0b1 as well. For example:

`pip install azure-core==1.0.0b1 azure-storage-queue==12.0.0b1`

**Fixes and improvements**
- General refactor of duplicate and shared code.
Expand Down