Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only import aiohttp when necessary #6496

Merged
merged 1 commit into from
Jul 29, 2019
Merged

Only import aiohttp when necessary #6496

merged 1 commit into from
Jul 29, 2019

Conversation

chlowell
Copy link
Member

AsyncPipelineClient should only import AioHttpTransport when no transport is provided.

@chlowell chlowell added Client This issue points to a problem in the data-plane of the library. Azure.Core labels Jul 25, 2019
@chlowell chlowell requested review from lmazuel and johanste July 25, 2019 20:23
@chlowell chlowell self-assigned this Jul 25, 2019
@adxsdk6
Copy link

adxsdk6 commented Jul 25, 2019

Can one of the admins verify this patch?

@chlowell chlowell force-pushed the default-async-transport branch from 2408572 to bdfb7c7 Compare July 26, 2019 20:56
lmazuel
lmazuel approved these changes Jul 29, 2019
View reviewed changes
Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chlowell chlowell merged commit 9d537eb into Azure:master Jul 29, 2019
@chlowell chlowell deleted the default-async-transport branch July 29, 2019 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryevdv bryevdv bryevdv approved these changes

@lmazuel lmazuel lmazuel approved these changes

@johanste johanste Awaiting requested review from johanste

@xiangyan99 xiangyan99 Awaiting requested review from xiangyan99

Assignees

@chlowell chlowell

Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chlowell @adxsdk6 @lmazuel @bryevdv