Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Key Vault] Linting updates for pylint 3.2.5 #37241

Merged
merged 6 commits into from
Sep 9, 2024
Merged

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Sep 7, 2024

Description

Resolves #34160 and #34158. Almost all changes are to include keyword-only arguments in method signatures, with the rest mostly removing extraneous pylint suppressions.

Validating next-pylint pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4116741&view=logs&j=e5b925a9-9650-5321-24fd-5d9499fe02b8&t=e1fa7d9e-8471-5a74-cd7d-e1c9a992e07e

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@mccoyp mccoyp added KeyVault Client This issue points to a problem in the data-plane of the library. pylint labels Sep 7, 2024
@mccoyp
Copy link
Member Author

mccoyp commented Sep 7, 2024

/azp run python - keyvault - tests-weekly

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mccoyp
Copy link
Member Author

mccoyp commented Sep 7, 2024

/azp run python - keyvault - tests-weekly

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mccoyp mccoyp marked this pull request as ready for review September 7, 2024 02:40
@azure-sdk
Copy link
Collaborator

azure-sdk commented Sep 7, 2024

API change check

API changes are not detected in this pull request.

@mccoyp mccoyp merged commit e923189 into Azure:main Sep 9, 2024
19 checks passed
@mccoyp mccoyp deleted the kv-pylint-3.2.5 branch September 9, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault pylint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azure-keyvault-certificates needs linting updates for pylint version 3.2.5
3 participants