Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoRelease] t2-oracledatabase-2024-05-23-80615(can only be merged by SDK owner) #35744

Merged

Conversation

azure-sdk
Copy link
Collaborator

@azure-sdk
Copy link
Collaborator Author

@ChenxiJiang333
Copy link
Member

/azp run prepare-pipelines

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ChenxiJiang333
Copy link
Member

/check-enforcer override

@ChenxiJiang333 ChenxiJiang333 merged commit 74509c2 into Azure:main May 30, 2024
4 checks passed
@azure-sdk azure-sdk deleted the t2-oracledatabase-2024-05-23-80615 branch June 2, 2024 09:12
@@ -0,0 +1,5 @@
# Release History
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChenxiJiang333 why is this in the "Oracle" directory? Generally the service directory matches the name of the package so oracledatabase in this case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for feedback and we will rename the folder soon.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChenxiJiang333 why is this in the "Oracle" directory? Generally the service directory matches the name of the package so oracledatabase in this case.

My fault for not checking the output folder config, has made a quick fix on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants