Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Add concat function to crc64 extension #35441

Merged
merged 1 commit into from
May 4, 2024

Conversation

jalauzon-msft
Copy link
Member

@jalauzon-msft jalauzon-msft commented May 1, 2024

Adds a new concat method to the crc64 extension that allows for concatenating two crc64 checksums together without knowing the original data. This will be needed for overall crc calculations in partitioned upload methods.

Also changes the name of the compute function to just compute and includes a couple of organizational/test changes as well.

@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label May 1, 2024
Copy link
Member

@vincenttran-msft vincenttran-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the testcases are passing 😄

@jalauzon-msft jalauzon-msft merged commit 8e6ed95 into Azure:main May 4, 2024
26 checks passed
@jalauzon-msft jalauzon-msft deleted the extensions-concat branch May 4, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants