[Storage] [STG93 GA] APIView Feedback #35331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenttran-msft
requested review from
annatisch,
jalauzon-msft and
weirongw23-msft
as code owners
...torage/azure-storage-file-datalake/azure/storage/filedatalake/_data_lake_directory_client.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-file-share/azure/storage/fileshare/_share_client.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-file-share/azure/storage/fileshare/aio/_file_client_async.py
Outdated
Show resolved
Hide resolved
|
API change check APIView has identified API level changes in this PR and created following API reviews. azure-storage-file-share |
…ces to be keywords not params
sdk/storage/azure-storage-blob/azure/storage/blob/_quick_query_helper.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/azure/storage/blob/_quick_query_helper.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/azure/storage/blob/_shared/models.py
Outdated
Show resolved
Hide resolved
jalauzon-msft
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title states... pending some revision but need to locally gen and pass back into APIView to check for
metadataissues going away, then need to check sphinx for theupndocstring change. Once that looks good, need to take the good pattern and propagate to allupndocstrings.