Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SB] Catch websocket exception #34859

Merged
merged 4 commits into from
Apr 30, 2024
Merged

[SB] Catch websocket exception #34859

merged 4 commits into from
Apr 30, 2024

Conversation

l0lawrence
Copy link
Member

Fixes #34300

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@l0lawrence l0lawrence marked this pull request as ready for review April 29, 2024 21:32
@l0lawrence l0lawrence requested a review from annatisch as a code owner April 29, 2024 21:32
@l0lawrence
Copy link
Member Author

/azp run python - servicebus - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@l0lawrence
Copy link
Member Author

/azp run python - eventhub - tests

@l0lawrence
Copy link
Member Author

/azp run python - servicebus - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@l0lawrence
Copy link
Member Author

l0lawrence commented Apr 30, 2024 •
edited
Loading

/check-enforcer override

@github-actions GitHub Actions
Copy link

For help using check enforcer, see https://aka.ms/azsdk/checkenforcer

Available commands:

  • /check-enforcer evaluate - Re-evaluate existing pipeline statuses for PR
  • /check-enforcer override - Ignore any pipeline missing or failed statuses for PR
  • /check-enforcer help - Add this comment

If you are initializing a new service, follow the new service docs. If no Azure Pipelines are desired, run /check-enforcer override.

@l0lawrence
Copy link
Member Author

/check-enforcer override

@l0lawrence l0lawrence enabled auto-merge (squash) April 30, 2024 15:21
@l0lawrence l0lawrence disabled auto-merge April 30, 2024 15:24
@l0lawrence l0lawrence merged commit 5fd2c52 into Azure:main Apr 30, 2024
44 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swathipil swathipil swathipil left review comments

@kashifkhan kashifkhan kashifkhan approved these changes

@annatisch annatisch Awaiting requested review from annatisch annatisch is a code owner

Assignees
No one assigned
Labels
Service Bus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uncaught WebSocketConnectionClosedException
4 participants
@l0lawrence @azure-sdk @kashifkhan @swathipil