-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ml] Enable strict sphinx check #34688
Conversation
@kristapratico The only remaining issues we're seeing for azure-ai-ml strict_sphinx compliance is a "duplicate object description" warning. It seems the root of this is having an object exported in multiple module namespaces (i.e. The error messages suggest using :no_index: in the docstring, but I haven't found a way to make that work and I don't see any examples in the azure-sdk-for-python repository of other packages using it. What's your recommendation for dealing with this error? |
@diondrapeck we should not have the same object exported in multiple module namespaces. We need to figure out for each type whether it should be imported at the parent or child namespace, and then we can use some init-level getattr magic to remove the type from dunder all (see here for an example) and include a deprecation warning to say that the specific type being imported will eventually be removed. cc @annatisch |
…icate object exposures
API change check APIView has identified API level changes in this PR and created following API reviews. |
Done! Thank you. |
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines