[Cosmos] fixing bug with not passing kwargs/ response_hook in create_container_if_not_exists
#34286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simorenoh
requested review from
kushagraThapar,
xinlian12,
annatisch and
bambriz
as code owners
annatisch
reviewed
Feb 12, 2024
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
annatisch
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Thanks @simorenoh - I think this looks good.
Though it might be good to run a quick local test for the specific customer scenario (i.e. passing in response_hook for both a new and pre-existing container) before we close out the issue.
|
/azp run python - cosmos - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing this issue pointing out a gap in our SDK's response_hook behavior for certain methods.