[AMQP] Fix Filter Set Encoding For 2 Char Length Session id #32860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashifkhan
requested review from
annatisch,
swathipil and
l0lawrence
as code owners
|
No pipelines are associated with this pull request. |
|
/azp run python - servicebus - tests |
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
API change check API changes are not detected in this pull request. |
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - eventhub - tests |
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdk/servicebus/azure-servicebus/azure/servicebus/_pyamqp/_encode.py
Outdated
Show resolved
Hide resolved
conniey
reviewed
Nov 1, 2023
|
/azp run python - eventhub - tests |
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
l0lawrence
reviewed
Nov 6, 2023
|
/azp run python - servicebus - tests |
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
swathipil
reviewed
Nov 7, 2023
swathipil
reviewed
Nov 8, 2023
|
/azp run python - servicebus - tests |
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
swathipil
approved these changes
Nov 13, 2023
kashifkhan
force-pushed
the
peek_error
branch
from
2fd9880 to
15e6ce9
Compare
kashifkhan
force-pushed
the
peek_error
branch
from
15e6ce9 to
769a33f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the case when a session id was of length 2. There was a logic error in encode that would try to do try/except on the passed in data and improperly split the values leading to an error from the service
The link contains invalid filter type. System only support Jms or Apache selector filter type but we found type 'Microsoft.ServiceBus.Messaging.Amqp.Encoding.DescribedType' associated with key 'com.microsoft:session-filter'.The fix was to make sure strs or bytes would not be attempted to be unpacked.