Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cosmos] api review changes #31532

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Conversation

simorenoh
Copy link
Member

Renaming the variable for its shorter variant - since it is a key word argument, users who use this option would have found it through our CHANGELOG or through the typehint explaining what it does, and as such we do not need the rest of the name.

bambriz
bambriz previously approved these changes Aug 8, 2023
@simorenoh simorenoh requested a review from bambriz August 8, 2023 22:50
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-cosmos

@simorenoh simorenoh dismissed bambriz’s stale review August 8, 2023 22:59

need additional conversation

@simorenoh simorenoh enabled auto-merge (squash) August 9, 2023 00:45
@simorenoh simorenoh merged commit 486b171 into Azure:main Aug 9, 2023
@simorenoh simorenoh deleted the api-review-changes branch August 9, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants