Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WorkspaceHub] Update enable isolation flag and purge flag support for workspaceHub #31310

Merged
merged 6 commits into from
Jul 26, 2023
Merged

[WorkspaceHub] Update enable isolation flag and purge flag support for workspaceHub #31310

merged 6 commits into from
Jul 26, 2023

Conversation

ZhidaLiu
Copy link
Member

@ZhidaLiu ZhidaLiu commented Jul 25, 2023 •
edited
Loading

Description

  1. Add data_isolation_enabled support for workspaceHub.
  2. Add permenant_delete flag support for workspaceHub delete operation.
  3. Add missing changelog for workspaceHub/Project workspace support.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ZhidaLiu
reformat code
d620207 
reformat code
@ZhidaLiu ZhidaLiu force-pushed the user/zhili/HubUpdate branch from 7c6b8fc to d620207 Compare July 25, 2023 22:40
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-ml

@ZhidaLiu
Address comments and fix tests
931978d 
run black

revert some changes
@ZhidaLiu ZhidaLiu requested a review from seanyao1 July 26, 2023 21:37
@ZhidaLiu ZhidaLiu requested a review from mingweihe as a code owner July 26, 2023 22:06
@seanyao1 seanyao1 enabled auto-merge (squash) July 26, 2023 22:12
@seanyao1 seanyao1 merged commit 674698c into Azure:main Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MilesHolland MilesHolland MilesHolland approved these changes

@needuv needuv needuv approved these changes

@seanyao1 seanyao1 seanyao1 approved these changes

@paulshealy1 paulshealy1 Awaiting requested review from paulshealy1 paulshealy1 is a code owner

@singankit singankit Awaiting requested review from singankit

@diondrapeck diondrapeck Awaiting requested review from diondrapeck

@luigiw luigiw Awaiting requested review from luigiw

@kdestin kdestin Awaiting requested review from kdestin

@nemanjarajic nemanjarajic Awaiting requested review from nemanjarajic

@nthandeMS nthandeMS Awaiting requested review from nthandeMS

@mingweihe mingweihe Awaiting requested review from mingweihe

Assignees
No one assigned
Labels
Machine Learning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ZhidaLiu @azure-sdk @seanyao1 @needuv @MilesHolland