Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Proxy] Clarify relevant documentation in testing guides #30827

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Jun 20, 2023

Description

Python's test proxy documentation currently suggests that users may have to set up the test proxy manually by using azure-sdk-tools's instructions (a partner team recently raised this issue). This PR clarifies that the documentation in azure-sdk-tools is technical reference and is unnecessary for test configuration. Related: Azure/azure-sdk-tools#6368

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@mccoyp mccoyp added Docs test-proxy Anything relating to test-proxy requests or issues. labels Jun 20, 2023
@mccoyp mccoyp merged commit 6087746 into main Jun 20, 2023
@mccoyp mccoyp deleted the proxy-doc-clarify branch June 20, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs test-proxy Anything relating to test-proxy requests or issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants