Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EventHubs] Update process span tracing logic #30537

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

pvaneck
Copy link
Member

@pvaneck pvaneck commented May 25, 2023

In the case of event handling on a per-message basis, the process span should be a direct child of the message context. This change adds the logic to do so.

Additional context: https://gist.github.com/lmolkova/e4215c0f44a49ef824983382762e6b92#processing-messages

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@pvaneck pvaneck force-pushed the eventhub-process-trace branch from a168ad7 to ef59b65 Compare May 31, 2023 00:13
In the case of event handling on a per-message basis, the process span
should be a direct child of the message context. This change adds the
logic to do so.

Live tests were also added to test receive/process span tracing.

Signed-off-by: Paul Van Eck <[email protected]>
@pvaneck pvaneck force-pushed the eventhub-process-trace branch from ef59b65 to a8bc075 Compare May 31, 2023 00:24
@pvaneck
Copy link
Member Author

pvaneck commented May 31, 2023

/azp run python - eventhub - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pvaneck pvaneck marked this pull request as ready for review May 31, 2023 02:42
Copy link
Member

@swathipil swathipil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@pvaneck pvaneck merged commit 52b431f into Azure:main Jun 23, 2023
@pvaneck pvaneck deleted the eventhub-process-trace branch June 23, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants