Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[formrecognizer] Add classifier administration methods #29466

Merged
merged 14 commits into from
Mar 28, 2023
Merged

[formrecognizer] Add classifier administration methods #29466

merged 14 commits into from
Mar 28, 2023

Conversation

catalinaperalta
Copy link
Member

@catalinaperalta catalinaperalta commented Mar 20, 2023 •
edited by kristapratico
Loading

This PR adds the following administration methods for classifiers:

  • get_document_classifier
  • list_document_classifiers
  • delete_document_classifier
  • begin_build_document_classifier

Related issues #29464

Krista TODO

  • add training files/build classifier to shared training acc
  • add begin_build_document_classifier
  • regenerate with correct poller
  • patch in models
  • add container sas url to samples/tests/test-resources.json
  • main
  • docstrings
  • tests for build/get/list/delete
  • rerecord
  • sample for build / adjust sample for mgmt
  • changelog
  • make sure live tests work for tests/samples
  • add aka.ms link to docs: https://aka.ms/azsdk/formrecognizer/buildclassifiermodel

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-formrecognizer

@kristapratico kristapratico marked this pull request as ready for review March 24, 2023 23:36
kinelski
kinelski approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@kinelski kinelski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major issues. LGTM.

@kristapratico kristapratico merged commit 289f3be into Azure:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinelski kinelski kinelski approved these changes

@kristapratico kristapratico Awaiting requested review from kristapratico

@iscai-msft iscai-msft Awaiting requested review from iscai-msft

@witemple-msft witemple-msft Awaiting requested review from witemple-msft

@samvaity samvaity Awaiting requested review from samvaity

@HarshaNalluru HarshaNalluru Awaiting requested review from HarshaNalluru

Assignees
No one assigned
Labels
Cognitive - Form Recognizer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@catalinaperalta @azure-sdk @kinelski @kristapratico