Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types in poller #29228

Merged
merged 60 commits into from
Jul 6, 2023
Merged

Types in poller #29228

merged 60 commits into from
Jul 6, 2023

Conversation

lmazuel
Copy link
Member

@lmazuel lmazuel commented Mar 8, 2023

No description provided.

@lmazuel lmazuel requested a review from kristapratico March 8, 2023 23:56
@ghost ghost added the Azure.Core label Mar 8, 2023
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-core

@lmazuel lmazuel marked this pull request as ready for review April 14, 2023 23:26
annatisch
annatisch reviewed Jun 30, 2023
View reviewed changes
Copy link
Member

@annatisch annatisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a few tiny questions and comments, but I think it's generally ready to go :)

sdk/core/azure-core/azure/core/pipeline/policies/_utils.py Outdated Show resolved Hide resolved
sdk/core/azure-core/azure/core/polling/_poller.py Outdated Show resolved Hide resolved
sdk/core/azure-core/azure/core/rest/_helpers.py Show resolved Hide resolved
sdk/core/azure-core/tests/test_base_polling.py Show resolved Hide resolved
sdk/core/azure-core/azure/core/polling/base_polling.py Show resolved Hide resolved
sdk/core/azure-core/azure/core/polling/base_polling.py Show resolved Hide resolved
sdk/core/azure-core/azure/core/polling/base_polling.py Show resolved Hide resolved
sdk/core/azure-core/azure/core/polling/base_polling.py Outdated Show resolved Hide resolved
sdk/core/azure-core/azure/core/polling/base_polling.py Show resolved Hide resolved
sdk/core/azure-core/azure/core/polling/base_polling.py Show resolved Hide resolved
@lmazuel lmazuel mentioned this pull request Jul 5, 2023
Open
@lmazuel lmazuel merged commit 8f06d2c into main Jul 6, 2023
@lmazuel lmazuel deleted the polling_types branch July 6, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristapratico kristapratico kristapratico left review comments

@johanste johanste johanste left review comments

@xiangyan99 xiangyan99 xiangyan99 left review comments

@annatisch annatisch annatisch approved these changes

@kashifkhan kashifkhan kashifkhan approved these changes

@tjprescott tjprescott Awaiting requested review from tjprescott

@iscai-msft iscai-msft Awaiting requested review from iscai-msft iscai-msft is a code owner

Assignees
No one assigned
Labels
Azure.Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lmazuel @azure-sdk @kashifkhan @annatisch @xiangyan99 @johanste @kristapratico