[Storage] Fix Storage CredScan warnings and update baseline #29005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalauzon-msft
requested review from
scbedd,
weshaggard,
benbp,
annatisch and
vincenttran-msft
as code owners
ghost
added
the
|
API change check API changes are not detected in this pull request. |
mccoyp
approved these changes
Feb 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes all of the Storage CredScan warnings that were for test encryption keys in test files. Fixed by switching to use existing keys in Storage
fake_credentials.pyfile that is already suppressed.Also removed these warnings from the baseline and removed a bunch of old Storage warnings from the baseline for recoding files that no longer exist. No more Storage suppressions in the baseline!