[Monitor][Query] Improve typing #28175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
sdk/monitor/azure-monitor-query/azure/monitor/query/_exceptions.py
Outdated
Show resolved
Hide resolved
pvaneck
force-pushed
the
logs-error-typing
branch
from
b8636f1 to
3d93e91
Compare
kristapratico
approved these changes
Jan 10, 2023
This enables the mypy and verifytypes checks in the CI, and also adds some typing improvements in order to pass the mypy check. Signed-off-by: Paul Van Eck <[email protected]>
* Use class attribute style typing * Class ordering in models file was changed a bit to allow for class attribute typing. * Enable pyright check and fix corresponding errors Signed-off-by: Paul Van Eck <[email protected]>
Signed-off-by: Paul Van Eck <[email protected]>
Signed-off-by: Paul Van Eck <[email protected]>
pvaneck
force-pushed
the
logs-error-typing
branch
from
afb0cf6 to
fa6e865
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the mypy, pyright, and verifytypes checks in the CI, and also adds some typing improvements in order to pass the checks.