Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asset management script #27676

Merged
merged 4 commits into from
Dec 6, 2022
Merged

Add asset management script #27676

merged 4 commits into from
Dec 6, 2022

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Nov 24, 2022

Description

Resolves #27015. This adds a script to azure-sdk-for-python/scripts for managing out-of-repo recording assets. It really just fetches git-related environment variables that we need for repository operations in a Docker container so users don't have to provide them to the command line.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@mccoyp mccoyp added EngSys This issue is impacting the engineering system. test-enhancement labels Nov 24, 2022
@mccoyp mccoyp requested a review from scbedd November 24, 2022 00:28
@mccoyp mccoyp marked this pull request as ready for review December 5, 2022 23:15
Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bunch of nitpicky feedback. Nothing that will stop this thing from working.

@mccoyp mccoyp force-pushed the proxy-push-script branch from 320bedf to f0ab71d Compare December 6, 2022 04:37
@mccoyp mccoyp force-pushed the proxy-push-script branch from f0ab71d to 6fdd40e Compare December 6, 2022 04:39
@mccoyp
Copy link
Member Author

mccoyp commented Dec 6, 2022

/check-enforcer override

@mccoyp mccoyp merged commit 82c2a2a into Azure:main Dec 6, 2022
@mccoyp mccoyp deleted the proxy-push-script branch December 6, 2022 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EngSys This issue is impacting the engineering system. test-enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Test Proxy] Write script for pushing recording assets
2 participants