Fix logging and new name for allowlist #27673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmazuel
requested review from
annatisch,
johanste,
xiangyan99,
tjprescott,
iscai-msft and
kashifkhan
as code owners
|
API change check API changes are not detected in this pull request. |
annatisch
approved these changes
Nov 24, 2022
| class HttpLoggingPolicy(SansIOHTTPPolicy): | ||
| @property | ||
| def DEFAULT_HEADERS_WHITELIST(cls): | ||
| return cls.DEFAULT_HEADERS_ALLOWLIST |
There was a problem hiding this comment.
Do we want to issue a deprecation warning if this is used? Or will that be too noisy for the time being?
There was a problem hiding this comment.
I think it's too noisy, we don't have any reasons to remove it for now. Maybe if we feel it becomes a maintenance burden, we can add it later when it was not documented for months
| @@ -1,5 +1,17 @@ | |||
| # Release History | |||
|
|
|||
| ## 1.3.3 (Unreleased) | |||
There was a problem hiding this comment.
This change is a patch, not a minor?
There was a problem hiding this comment.
Is that really a new feature?
iscai-msft
approved these changes
Nov 28, 2022
|
The few remaining red CI are unrelated, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #26331
Note: It's incredibly more difficult to hide an alias to a class property than it seems, as there is no class level
getattr. But the metaclass option works fine, and is not read by Sphinx: