Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common-sense tox environment skipping #27487

Merged
merged 14 commits into from
Nov 15, 2022
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .vscode/cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@
"tools/azure-sdk-tools/setup.py"
],
"words": [
"qnamaker",
"mindependency",
"automl",
"pyyaml",
"CONLL",
Expand Down
2 changes: 1 addition & 1 deletion doc/dev/static_type_checking.md
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ All client libraries in the Python SDK repo are automatically opted in to runnin
reason why a particular library should not run type checking, it is possible to add that library to a block list to prevent mypy/pyright
from running checks.

1) Place the package name on the appropriate block list: [eng/tox/environment_exclusion_list.py](https://github.com/Azure/azure-sdk-for-python/blob/main/eng/tox/environment_exclusion_list.py).
1) Place the package name on the appropriate block list: [tools/azure-sdk-tools/ci_tools/environment_exclusions.py](https://github.com/Azure/azure-sdk-for-python/blob/main/tools/azure-sdk-tools/ci_tools/environment_exclusions.py).
2) Open an issue tracking that "library-name" should be opted in to running type checking

> Note: Blocking your library from type checking is a *temporary* state. It is expected that checks are re-enabled as soon as possible.
Expand Down
2 changes: 1 addition & 1 deletion eng/pipelines/templates/steps/run_pylint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ steps:
"$(TargetingString)"
--mark_arg="${{ parameters.TestMarkArgument }}"
--service="${{ parameters.ServiceDirectory }}"
--toxenv="lint"
--toxenv="pylint"
--disablecov
--filter-type="Omit_management"
env: ${{ parameters.EnvVars }}
Expand Down
Loading