Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLU+QA] update polling_interval per service recommendation #26297

Merged
merged 2 commits into from
Sep 22, 2022

Conversation

kristapratico
Copy link
Member

Resolves #26108 #26109

Request from the service team to update the default polling_interval to 5 seconds for both QA and CLU. This was previously defaulting to the azure-core default of 30 seconds.

@kristapratico
Copy link
Member Author

/azp run python - cognitivelanguage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@heaths
Copy link
Member

heaths commented Sep 20, 2022

.NET defaults to 1s unless the Retry-After header is sent. @peytonfraser @kayousef why isn't the service sending this header if that's what it recommends?

@kristapratico
Copy link
Member Author

.NET defaults to 1s unless the Retry-After header is sent. @peytonfraser @kayousef why isn't the service sending this header if that's what it recommends?

Just to give background, in Text Analytics we've always used 5 secs from what the service team recommended a long time ago. This is updating CLU and QA to use the same per my conversation with Mikael.

The 5 seconds is used as the initial polling interval between the POST and the first GET (before we have a chance to see a Retry-After header). After that, if the service returns a Retry-After header, then that's what is used in subsequent calls (like .NET).

@kristapratico kristapratico merged commit b7953bc into Azure:main Sep 22, 2022
@kristapratico kristapratico deleted the cog-update-polling-interval branch September 22, 2022 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QA] update polling_interval
3 participants