Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KeyVault] Fix generated reference documentation for KeyVaultClient #2619

Closed
wants to merge 1 commit into from

Conversation

schaabs
Copy link
Member

@schaabs schaabs commented May 23, 2018

  • Renamed CustomKeyVaultClient to KeyVaultClient to fix 'alias' documentation
  • updated azure.keyvault.rst to pull in inherited members
  • removed unneeded / outdated rst files

@schaabs schaabs requested a review from lmazuel May 23, 2018 23:25
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@codecov-io
Copy link

codecov-io commented May 23, 2018

Codecov Report

Merging #2619 into keyvault_1.0_preview will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           keyvault_1.0_preview    #2619   +/-   ##
=====================================================
  Coverage                  56.3%    56.3%           
=====================================================
  Files                      6530     6530           
  Lines                    141715   141715           
=====================================================
  Hits                      79786    79786           
  Misses                    61929    61929
Impacted Files Coverage Δ
...keyvault/azure/keyvault/custom/key_vault_client.py 96.66% <100%> (ø) ⬆️
azure-keyvault/azure/keyvault/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e12bdb...3d3f3c6. Read the comment docs.

@schaabs schaabs force-pushed the keyvault_1.0_preview branch from 4e0cd4c to f2a92ab Compare June 27, 2018 20:45
@lmazuel
Copy link
Member

lmazuel commented Jun 27, 2018

@schaabs should we rebase this on master now?

@schaabs schaabs closed this Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants