Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pinned version of wrapt to one that is compatible with py311 #25828

Merged
merged 4 commits into from
Aug 24, 2022

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Aug 23, 2022

See title.

@scbedd scbedd requested a review from mccoyp August 23, 2022 22:43
@scbedd
Copy link
Member Author

scbedd commented Aug 23, 2022

/azp run python - core - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scbedd
Copy link
Member Author

scbedd commented Aug 23, 2022

The update to wrapt is causing a pip resolver thrash during installation (hence why docs build isn't ever completing). I gotta figure out where in the graph the break is coming from.

… the version of pylint we install to ensure we get the new version of wrapt that is compatible with py311
@scbedd
Copy link
Member Author

scbedd commented Aug 24, 2022

I believe my latest commit should resolve this.

The issue is that we pin pylint==2.9.3. pylint==2.9.3 has a dependency on wrapt==1.12.1. When we update the pinned dependency of wrapt in test_tools.txt to 1.14.1 in all cases, this puts us in an unresolvable state. After that, pip just thrashes forever.

To address this, I've updated the pins to include two new ones for py311 only that will prevent the issues from biting us.

eng/ci_tools.txt Outdated Show resolved Hide resolved
@scbedd scbedd merged commit 9c19036 into Azure:main Aug 24, 2022
mccoyp pushed a commit to mccoyp/azure-sdk-for-python that referenced this pull request Sep 22, 2022
…ure#25828)

* pylint 2.9.3 requires wrapt 1.12.1. to address this on py311, we bump the version of pylint we install to ensure we get the new version of wrapt that is compatible with py311
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Oct 9, 2023
[Hub Generated] Review request for Microsoft.ResourceHealth to add version preview/2023-10-01-preview (Azure#25828)

* Adds base for updating Microsoft.ResourceHealth from version preview/2023-07-01-preview to version 2023-10-01-preview

* Updates readme

* Updates API version in new specs and examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants