[Eventhub] Fix Blocking Behavior of Buffered Producer Flush #25406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashifkhan
requested review from
annatisch,
swathipil and
l0lawrence
as code owners
ghost
added
the
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
swathipil
reviewed
Jul 26, 2022
sdk/eventhub/azure-eventhub/samples/async_samples/send_buffered_mode_async.py
Outdated
Show resolved
Hide resolved
l0lawrence
reviewed
Jul 26, 2022
sdk/eventhub/azure-eventhub/azure/eventhub/_buffered_producer/_buffered_producer.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/azure/eventhub/aio/_buffered_producer/_buffered_producer_async.py
Outdated
Show resolved
Hide resolved
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
annatisch
reviewed
Aug 1, 2022
sdk/eventhub/azure-eventhub/azure/eventhub/_buffered_producer/_buffered_producer.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/azure/eventhub/aio/_buffered_producer/_buffered_producer_async.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/tests/livetest/asynctests/test_buffered_producer_async.py
Show resolved
Hide resolved
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/check-enforcer override |
annatisch
reviewed
Aug 2, 2022
sdk/eventhub/azure-eventhub/azure/eventhub/_buffered_producer/_buffered_producer.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/azure/eventhub/aio/_buffered_producer/_buffered_producer_async.py
Outdated
Show resolved
Hide resolved
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/check-enforcer override |
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
annatisch
approved these changes
Aug 12, 2022
wonder6845
pushed a commit
to wonder6845/azure-sdk-for-python
that referenced
this pull request
Aug 23, 2022
) * changes to make get non blocking async * make emptying a queue non blocking * test * reset sample async * test * new line * remove second lock * sum over all the partitions * fix async tests * remove debug print * lock around queue * fix pylint * changelog * remove print * reset cur_buffer_length outside while loop * increase waiting time to receive events * remove sleep on add
mccoyp
pushed a commit
to mccoyp/azure-sdk-for-python
that referenced
this pull request
Sep 22, 2022
) * changes to make get non blocking async * make emptying a queue non blocking * test * reset sample async * test * new line * remove second lock * sum over all the partitions * fix async tests * remove debug print * lock around queue * fix pylint * changelog * remove print * reset cur_buffer_length outside while loop * increase waiting time to receive events * remove sleep on add
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-python
that referenced
this pull request
Aug 28, 2023
update typescript.md in resource (Azure#25406) * update typescript.md in resource * update
This was referenced Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in reference to the issue #23510
Thanks to @annatisch for helping with the bug :)
queue.getwas not needed for both sync & async. Flush should simply empty the queue, reset the buffer length and move on. This is whyblock=Falseis passed in andcur_buffered_lenis reset on Empty exceptionput_eventas it is modifying some shared variables such ascurr_batch,cur_buffered_lenas well as attempts aflushwhen the queue is full. This way we won't be adding things into the queue while flushing, leading to an infinite loop.