Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ML Sync - Resolve invalid base error #25254

Merged
merged 1 commit into from
Jul 15, 2022
Merged

ML Sync - Resolve invalid base error #25254

merged 1 commit into from
Jul 15, 2022

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Jul 15, 2022

Example PR

This works.

@scbedd scbedd requested review from weshaggard and benbp as code owners July 15, 2022 21:13
@scbedd
Copy link
Member Author

scbedd commented Jul 15, 2022

/check-enforcer override

@scbedd scbedd changed the title ML Sync - Resolve Invalid base error ML Sync - Resolve invalid base error Jul 15, 2022
@scbedd
Copy link
Member Author

scbedd commented Jul 15, 2022

/check-enforcer override

@scbedd scbedd merged commit da7d0b7 into main Jul 15, 2022
@scbedd scbedd deleted the hotfix/resolve-base-error branch July 15, 2022 21:18
jeremydvoss pushed a commit to jeremydvoss/azure-sdk-for-python that referenced this pull request Jul 21, 2022
@scbedd @jeremydvoss
ML Sync - Resolve "invalid base" error (Azure#25254)
7b12601
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Aug 22, 2023
@pdaru @NickKeller
@jaiveerk @jatakiajanvi12 @matthchr @wenjungaogaogao @norshtein @sallasindhuja @huizhifan @SanyaKochhar
CodeGen from PR 25254 in Azure/azure-rest-api-specs
0c35cd2 
[Hub Generated] Review request for Microsoft.ContainerService/aks to add version preview/2023-07-02-preview (Azure#25254)

* Adds base for updating Microsoft.ContainerService/aks from version preview/2023-06-02-preview to version 2023-07-02-preview

* Updates readme

* Updates API version in new specs and examples

* update readmes (Azure#25049)

* add new field resourceUID to managed cluster properties (Azure#25069)

* add new field resourceUID to managed cluster properties

https://msazure.visualstudio.com/CloudNativeCompute/_git/aks-rp/pullrequest/8416789

* update description

* Mark guardrailsProfile Version as not required (Azure#25081)

* Mark guardrailsProfile Version as not required

* Run prettier

---------

Co-authored-by: Nick Keller <[email protected]>

* Swagger Changes for Multiple DNS Zones for Web App Routing (Azure#25064)

* added web app routing changes for multiple dns zones

* modified examples

* Changes for unified azuremonitorprofile in Microsoft.ContainerService (Azure#25063)

* Changes for unified azuremonitorprofile

* Update prettier changes

* Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-07-02-preview/managedClusters.json

Co-authored-by: FumingZhang <[email protected]>

* Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-07-02-preview/managedClusters.json

Co-authored-by: FumingZhang <[email protected]>

---------

Co-authored-by: Janvi Jatakia (from Dev Box) <[email protected]>
Co-authored-by: FumingZhang <[email protected]>

* Add cost analysis to AKS preview Swagger (Azure#25082)

* update preview API to follow GA api - use one forceupgrade boolean in… (Azure#25099)

* update preview API to follow GA api - use one forceupgrade boolean instead of multiple overrides

* update msg

---------

Co-authored-by: Wenjun Gao <[email protected]>

* Mark trusted access role binding PUT and DELETE operation as async (Azure#25112)

* Mark trusted access role binding PUT and DELETE operation as async

* fix CI: update TA oepration's error to common type error

* Swagger for Machine API (Azure#25180)

* Swagger for Machine List, Get API

Related work items: #24759018

* Update managedClusters.json

* Update managedClusters.json

* Update MachineGet.json

adding new line

* Update MachineList.json

* Update managedClusters.json

* Update managedClusters.json

* Update managedClusters.json

* swagger: machine api

* swagger: machine api

* swagger:machine api

* swagger: machine api

* swagger: machine api

* swagger: machine api

* Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-07-02-preview/managedClusters.json

Co-authored-by: FumingZhang <[email protected]>

* swagger: machine api

* swagger: machine api

* swagger:  machine api

* swagger:machine api

* swagger:machine api

* swagger:machine api

---------

Co-authored-by: FumingZhang <[email protected]>

* Adding Guardrails version to public swagger (Azure#25085)

* Adding Guardrails version to public swagger

* renamed GetGuardrailsVersions.json

* Applied GetCollectionResponseSchema rule

* Ran prettier fix

* Minor change

* moving parametre into managedClusters.json

* GuardrailsAvailableVersion model change

* Updated version param reference

* Swagger SemanticValidation fix

* model changes

* prettier fix

* Added version in list response

* Changed  to resource in GET and added descriptions where needed

* Removed identifier in GuardrailsAvailableVersionsList

---------

Co-authored-by: Sindhuja Salla <[email protected]>

* Remove overlay vpa unused properties (Azure#25242)

* remove unused properties

* only remove from required section

* remove the whole properties

---------

Co-authored-by: zhifanhui <[email protected]>

* asm: update examples to use asm- prefix for revisions (Azure#25247)

* Revert "Mark trusted access role binding PUT and DELETE operation as async (Azure#25112)" (Azure#25233)

This reverts commit db24ef8bfbf6b214310af0872a923130e27ae1b6.

* fix AgentPoolNameParameter location

* Fuming zhang containerservice microsoft.container service 2023 07 02 preview (Azure#25433)

* adding requested properties.

* adding requested properties

* prettier check

* removing read-only constraint

---------

Co-authored-by: daru__ <[email protected]>
Co-authored-by: Nick Keller <[email protected]>
Co-authored-by: Nick Keller <[email protected]>
Co-authored-by: Jaiveer Katariya <[email protected]>
Co-authored-by: Janvi Jatakia <[email protected]>
Co-authored-by: Janvi Jatakia (from Dev Box) <[email protected]>
Co-authored-by: Matthew Christopher <[email protected]>
Co-authored-by: Wenjun Gao <[email protected]>
Co-authored-by: Wenjun Gao <[email protected]>
Co-authored-by: Tongyao Si <[email protected]>
Co-authored-by: sushmak295 <[email protected]>
Co-authored-by: sallasindhuja <[email protected]>
Co-authored-by: Sindhuja Salla <[email protected]>
Co-authored-by: huizhifan <[email protected]>
Co-authored-by: zhifanhui <[email protected]>
Co-authored-by: Sanya Kochhar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mccoyp mccoyp mccoyp approved these changes

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

@benbp benbp Awaiting requested review from benbp benbp is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scbedd @mccoyp