Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Handling AzureNamedKeyCredential in Python SDK #24967

Merged

Conversation

vincenttran-msft
Copy link
Member

@vincenttran-msft vincenttran-msft commented Jun 24, 2022

Still TODO for Blob completion:

  • Propagate all the changes to other places we accept credential

TODO for full support-complete:

  • Propagate changes to other 4 packages
  • Add a test for each package

Originally raised in #24836

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Jun 24, 2022
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jun 28, 2022

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-storage-blob
azure-storage-file-share
azure-storage-file-datalake
azure-storage-queue

@vincenttran-msft vincenttran-msft marked this pull request as ready for review June 29, 2022 18:07
@vincenttran-msft vincenttran-msft changed the title [Draft] Handling AzureNamedKeyCredential in Blob [Storage] Handling AzureNamedKeyCredential in Blob Jun 29, 2022
@vincenttran-msft vincenttran-msft changed the title [Storage] Handling AzureNamedKeyCredential in Blob [Storage] Handling AzureNamedKeyCredential in Python SDK Jun 30, 2022
@Azure Azure deleted a comment from check-enforcer bot Jun 30, 2022
@vincenttran-msft
Copy link
Member Author

/azp run python - storage - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vincenttran-msft
Copy link
Member Author

/azp run python - storage - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vincenttran-msft
Copy link
Member Author

/azp run python - storage - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vincenttran-msft vincenttran-msft merged commit 1844ef9 into Azure:main Jul 22, 2022
@vincenttran-msft vincenttran-msft deleted the vincenttran/credential_changes branch July 22, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage clients should handle AzureNamedKeyCredential as credential
3 participants